Opened 2 months ago

Last modified 4 days ago

#30924 needs_review enhancement

hs-v3: Implement proposal 305 - ESTABLISH_INTRO Cell DoS Defense Extension

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-spec, prop305, network-team-roadmap-august
Cc: Actual Points:
Parent ID: #29999 Points: 7
Reviewer: asn Sponsor: Sponsor27-must

Description

Ticket for implementing prop305 (see #30790).

Child Tickets

Change History (6)

comment:1 Changed 8 weeks ago by dgoulet

For this to be completed, it requires #15516 to be merged. There is quite a cross-over.

For now, on going development is in ticket30924_042_01.

comment:2 Changed 4 weeks ago by gaba

Keywords: network-team-roadmap-august added

comment:3 Changed 5 days ago by dgoulet

Reviewer: asn
Status: assignedneeds_review

Branch: ticket30924_042_01
PR: https://github.com/torproject/tor/pull/1232

This is working well with chutney. On today git master, the HS won't send the extension since no relay supports it.

The service side only honors the torrc options, it does NOT look at the consensus parameters. The intro point is the one looking at those if the cell extension is not seen.

comment:4 in reply to:  3 Changed 4 days ago by asn

Replying to dgoulet:

Branch: ticket30924_042_01
PR: https://github.com/torproject/tor/pull/1232

This is working well with chutney. On today git master, the HS won't send the extension since no relay supports it.

The service side only honors the torrc options, it does NOT look at the consensus parameters. The intro point is the one looking at those if the cell extension is not seen.

Did an initial high-level review of the code. I did not actually look at the nitty-gritty details (e.g. low-level parsing/encoding) yet. I'll also wait for the tor-dev thread with the intro point behavior.

comment:5 Changed 4 days ago by asn

Status: needs_reviewneeds_revision

comment:6 Changed 4 days ago by dgoulet

Status: needs_revisionneeds_review

Addressed most of the comments. I rebased/squashed the fixes and forced push (upon agreement with asn).

Note: See TracTickets for help on using tickets.