Opened 2 months ago

Last modified 2 months ago

#30943 new defect

Show Tor Browser version on Android

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-parity, tbb-torbutton
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It's is currently not easy to check the Tor Browser version on mobile. The about:tor page on desktop has the version number on the upper right corner but there is no equivalent for mobile yet.

The second piece that is confusing here is mentioned in https://blog.torproject.org/comment/282625#comment-282625 where the Firefox version is shown in about -> Tor Browser on the Settings menu. I guess we should keep the Firefox version as we do on the about Tor Browser dialog on desktop but amend it with the Tor Browser version (which we do as well). Might be a good child ticket.

Child Tickets

Change History (2)

comment:1 Changed 2 months ago by gk

Component: - Select a componentApplications/Tor Browser
Keywords: tbb-torbutton added
Owner: set to tbb-team

We have

    <div id="torbrowser-info">
      <div id="torbrowser-version"/>
      <div id="torbrowser-changelog-link"><a href="about:tbupdate">&aboutTor.viewChangelog.label;</a></div>
    </div>

in aboutTor.xhtml and

body[mobile] #torbrowser-info,
body[mobile] .searchbox,
body[mobile] .top .heading2,
body[mobile] #manual,
body[mobile] #mission {
  display: none;
}

Which is presumably why the version number is not shown on mobile. It's not clear why we decided to not show all the things in torbrowser-info on mobile but sysrqb thinks that might be due to about:tbupdate not be available there. I guess we could just set display:none; on mobile for torbrowser-changelog-link instead?

comment:2 in reply to:  1 Changed 2 months ago by mcs

Replying to gk:

We have

    <div id="torbrowser-info">
      <div id="torbrowser-version"/>
      <div id="torbrowser-changelog-link"><a href="about:tbupdate">&aboutTor.viewChangelog.label;</a></div>
    </div>

in aboutTor.xhtml and

body[mobile] #torbrowser-info,
body[mobile] .searchbox,
body[mobile] .top .heading2,
body[mobile] #manual,
body[mobile] #mission {
  display: none;
}

Which is presumably why the version number is not shown on mobile. It's not clear why we decided to not show all the things in torbrowser-info on mobile but sysrqb thinks that might be due to about:tbupdate not be available there. I guess we could just set display:none; on mobile for torbrowser-changelog-link instead?

I think so, yes.
Most of the hidden items were added during the #27111 work (commit 61deb44d0c07eb1ec1d71eac2f0a7aeca87ea054). Kathy and I introduced #torbrowser-info during our work on #29440 (commit 82a5f8665a6b5a7f5d4c78f0a526dfa16834ec7f).

Note: See TracTickets for help on using tickets.