Opened 4 months ago

Last modified 4 months ago

#30944 new defect

TBA - IllegalStateException: Not allowed to start service Intent

Reported by: mikehardy Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201906
Cc: sysrqb Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi there, it appears that if the Tor Browser for Android is set as the default WebView, it may be called upon as the system's default "CustomTabs" implementation, and be liable to respond to the "CustomTabsClient.warmup" API call, which starts it in the background.

Apparently there are cases where Tor Browser for Android will then take an Intent, and attempt to start a service Intent (instead of using Android 8+ APIs) which then causes an IllegalStateException to be thrown, which crashes the app that tried to call warmup

Corresponding issue: https://github.com/ankidroid/Anki-Android/issues/5337

Links are in there including a stack trace

I think this is the most relevant though, there's an upstream patch from Mozilla that may or may not be integrated, and may or may not need to be adapted into other areas: https://trac.torproject.org/projects/tor/ticket/29238#comment:3

Unfortunately I couldn't actually find a link to just look at the git repo source code for TBA, so I can't point deeper into to the issue

Child Tickets

Change History (1)

comment:1 Changed 4 months ago by gk

Cc: sysrqb added
Keywords: tbb-mobile TorBrowserTeam201906 added

Thanks for the detailed bug report, really appreciated. Our code lives at https://gitweb.torproject.org/tor-browser.git, the latest branch is tor-browser-60.7.0esr-9.0-1 (mobile/ contains all the mobile code).

Note: See TracTickets for help on using tickets.