Opened 4 months ago

Closed 4 months ago

#30963 closed defect (fixed)

Shellcheck tests should exclude src/rust/registry

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: Actual Points: 0
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

There are shell scripts that can get downloaded into src/rust/registry, but they are not in our control: we should tell shellcheck not to look at them.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by nickm

Actual Points: 0
Status: assignedneeds_review

Branch is bug30963; PR at https://github.com/torproject/tor/pull/1139 . Trivial fix.

comment:2 Changed 4 months ago by teor

It turns out that we're also checking .git and user-specified build directories, I opened #30967 for follow up.

comment:3 Changed 4 months ago by dgoulet

Keywords: asn-merge added
Reviewer: dgoulet
Status: needs_reviewmerge_ready

ack

comment:4 Changed 4 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged to master.

Note: See TracTickets for help on using tickets.