pre-push hook runs practracker unconditionally

Our pre-push hook script runs practracker whenever it exists. But we only want to run practracker on branches that are targeted for master.

I think perhaps we should change it to try making check-local? Or perhaps it could check for the existence of some other file that we could use to indicate whether we want practracker to run.

changed milestone to %Tor: 0.4.2.x-final

Trac:
Child Ticket(s): #31462 (moved)

added actualpoints::0.1 asn-merge component::core tor/tor git-scripts milestone::Tor: 0.4.2.x-final nickm-merge owner::teor points::0.1 priority::medium resolution::fixed reviewer::dgoulet severity::normal status::closed type::defect version::tor 0.4.1.1-alpha labels

Replying to nickm:

Our pre-push hook script runs practracker whenever it exists. But we only want to run practracker on branches that are targeted for master.

I think perhaps we should change it to try making check-local? Or perhaps it could check for the existence of some other file that we could use to indicate whether we want practracker to run.

Checking another file would be nice: I don't run configure to generate a Makefile in my upstream push directories, but I still want practracker to run on them.

Trac:
Owner: N/A to nickm
Status: new to accepted

I ran ahead and did this, since I'm getting annoyed about seeing practracker failures whenever I push an older branch.

See my branch ticket30979 with PR at https://github.com/torproject/tor/pull/1220 .

Trac:
Actualpoints: N/A to 0
Status: accepted to needs_review

Trac:
Reviewer: N/A to dgoulet

LGTM

Trac:
Status: needs_review to merge_ready
Keywords: git-scripts deleted, git-scripts asn-merge added

Merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

This ticket does not fix this issue:

• the pre-commit hook still calls practracker unconditionally
• the pre-push hook should never have added a duplicate call to practracker in #30051 (moved), because it already calls the pre-commit hook, which calls practracker

I'll create another PR that fixes these bugs.

Trac:
Resolution: fixed to N/A
Status: closed to reopened

See my PR which fixes this issue, I opened #31462 (moved) to get a different bug number, but updated both changes files:

• master: https://github.com/torproject/tor/pull/1241

Trac:
Owner: nickm to teor
Status: reopened to assigned
Keywords: git-scripts asn-merge deleted, git-scripts added
Actualpoints: 0 to 0.1
Version: N/A to Tor: 0.4.1.1-alpha
Points: N/A to 0.1

Trac:
Status: assigned to needs_review

lgtm;

Trac:
Status: needs_review to merge_ready
Keywords: git-scripts deleted, git-scripts nickm-merge asn-merge added

merged!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #31462 (moved)

moved to tpo/core/tor#30979 (closed)

mentioned in issue tpo/core/tor#31462 (closed)