Opened 16 months ago

Last modified 5 months ago

#30987 needs_information enhancement

[PATCH] Add support for seccomp on powerpc64

Reported by: shawnanastasio Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: 042-deferred-20190918
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

Attached is a small patch to enable support for building tor with seccomp on the ppc64 and ppc64le architectures.

Child Tickets

Attachments (1)

0001-Add-support-for-seccomp-on-powerpc64.patch (808 bytes) - added by shawnanastasio 16 months ago.
patch file

Download all attachments as: .zip

Change History (8)

Changed 16 months ago by shawnanastasio

patch file

comment:1 Changed 16 months ago by nickm

Milestone: Tor: 0.4.2.x-final
Status: newneeds_review

Have you tried this out? Did Tor run correctly with Sandbox 1 on those platforms?

comment:2 Changed 16 months ago by asn

Reviewer: nickm

comment:3 Changed 16 months ago by nickm

Looks reasonable, but I have no way to test it. Had anybody/can anybody try this out?

comment:4 Changed 15 months ago by nickm

Status: needs_reviewneeds_information

This needs somebody to try building and running with it.

comment:5 Changed 13 months ago by nickm

Keywords: 042-deferred-20190918 added
Milestone: Tor: 0.4.2.x-finalTor: unspecified

Deferring various tickets from 0.4.2 to Unspecified.

comment:6 Changed 5 months ago by JeremyRand

I might be able to test on ppc64le if someone can tell me exactly what I should be looking for. If tor manages to fully connect, and Firefox can load the Tor Check page via this tor instance, while Sandbox 1 is set in torrc, is that good enough to confirm that the patch is okay, or is there something more subtle that I should be looking for?

Do I need to test explicitly on BE as well, or is a successful test on ppc64le sufficient?

comment:7 Changed 5 months ago by nickm

Yeah, if it runs for a while with sandbox 1, that would be good. If you can test with BE, that would be helpful -- since this patch is about kernel ABI stuff, it the has possibility of being super platform-specific. But if you can't, just knowing it would work at all would be fine.

Note: See TracTickets for help on using tickets.