Opened 16 months ago

Last modified 5 months ago

#30990 new enhancement

checkSpace.pl: clean up our list of types

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 042-can, 044-deferred
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

checkSpace.pl has a list of types that are returned from function pointers, and uses it so that we don't complain about code like this:

  bool (*eq)(const void *a, const void *b);

(Without recognizing that bool is a type, practracker would think that we were calling a function named "bool", and complain that we had a space after a function call.)

In their review for #30864, catalyst notes that the current code in checkSpace.pl for this is unweildy, and suggests that we use a list instead. I concur.

Child Tickets

Change History (3)

comment:1 Changed 14 months ago by nickm

Keywords: 042-can added

comment:2 Changed 5 months ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.4.x-final

comment:3 Changed 5 months ago by nickm

Keywords: 044-deferred added
Milestone: Tor: 0.4.4.x-finalTor: unspecified

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Note: See TracTickets for help on using tickets.