Opened 4 months ago

Last modified 2 months ago

#31023 accepted defect

Add tests for tor-print-ed-signing-cert and other tools, and run them in CI

Reported by: teor Owned by: rl1987
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: technical-debt
Cc: rl1987 Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

We almost missed a memory safety bug in #31012, because our CI doesn't run our tools. We should write some quick tool tests, and run them in our CI.

Child Tickets

Change History (3)

comment:1 Changed 4 months ago by rl1987

Owner: set to rl1987
Status: newaccepted

I'll try to get this done next week.

comment:2 Changed 4 months ago by teor

Thanks - no particular hurry.

It would be nice to test two certificate files:

  • a generated file containing cert
  • a file committed to the repository containing a cert

Then we know the tool works on old and new files. (And that the generating tool hasn't broken.)

comment:3 Changed 2 months ago by dgoulet

Parent ID: #31012

Unparenting to close parent.

Note: See TracTickets for help on using tickets.