Opened 3 weeks ago

Last modified 3 weeks ago

#31027 needs_review defect

Coverity: circpadding: dead code in circpad_machine_remove_token

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: coverity
Cc: mikeperry, asn Actual Points:
Parent ID: Points:
Reviewer: mikeperry Sponsor:

Description

In circpad_machine_remove_token(), we check for state==NULL on line 1087, and then again on line 1107. Since state is not assigned between these points, the second check is dead code.

This is CID 1447298.

Child Tickets

Change History (3)

comment:1 Changed 3 weeks ago by asn

Please check the first commit of ​https://github.com/torproject/tor/pull/1160 which fixes both #31027 and #31024.

comment:2 Changed 3 weeks ago by asn

Status: newneeds_review

comment:3 Changed 3 weeks ago by asn

Reviewer: mikeperry
Note: See TracTickets for help on using tickets.