Migrate away from the custom websocket library

See comment:14:ticket:30998

Trac:
Child Ticket(s): #29125 (moved), #28726 (moved)

added component::circumvention/snowflake owner::arlolra priority::medium resolution::fixed reviewer::cohosh severity::normal status::closed type::defect labels

Trac:
Owner: N/A to arlolra
Status: new to assigned

Starting something for this in https://github.com/keroserene/snowflake/commits/trac31028 but haven't tested it yet.

Starting something for this in ​https://github.com/keroserene/snowflake/commits/trac31028 but haven't tested it yet.

Ok, tested with a local bridge and it seems to work.

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to cohosh

It's looking good. I left two comments on the commit.

Should we move to the Gorilla websocket library for the proxy-go instances as well? The GoDoc for the x/net websocket package suggests Gorilla since it is more actively maintained.

Trac:
Status: needs_review to needs_information

I had a look at this and my observations are the same as cohosh's in comment:5. Sending a CloseMessage before closing seems prudent as that's what the old code did.

Should we move to the Gorilla websocket library for the proxy-go instances as well?

Sure, IMO it's not as important because proxy-go only connects to a known server (not receiving connections from anywhere as the server does), and only needs to be compatible with the server's WebSocket implementation (unlike the server which has to be compatible with many browsers). It's a good idea anyway. I'd say let's get this ticket closed out first.

Trac:
Status: needs_information to merge_ready

Replying to dcf:

I had a look at this and my observations are the same as cohosh's in comment:5. Sending a CloseMessage before closing seems prudent as that's what the old code did.

Right, sorry for the omission. I merged a patch for that in, https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=abefae158716b9f56692ea16336c1f8185eda27e

and the bulk of this in, https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=c417fd5599c5d39951c606856c69a9f05941afd3

Should we move to the Gorilla websocket library for the proxy-go instances as well?

Sure, IMO it's not as important because proxy-go only connects to a known server (not receiving connections from anywhere as the server does), and only needs to be compatible with the server's WebSocket implementation (unlike the server which has to be compatible with many browsers). It's a good idea anyway. I'd say let's get this ticket closed out first.

I opened #32465 (moved) for that.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

mentioned in issue #29125 (moved)

moved to tpo/anti-censorship/pluggable-transports/snowflake#31028 (closed)