Opened 4 months ago

Closed 2 months ago

#31030 closed defect (fixed)

Coverity: Several warnings from test code

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: coverity asn-merge
Cc: Actual Points: .1
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Coverity gives a half dozen or so new warnings in our unit test code. These are all harmless, since they're test-only, but they are still worth fixing.

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by nickm

Actual Points: .1
Keywords: coverity added
Milestone: Tor: 0.4.2.x-final
Status: assignedneeds_review

See branch ticket31030 with PR at https://github.com/torproject/tor/pull/1154

comment:2 Changed 4 months ago by asn

Reviewer: teor

comment:3 Changed 2 months ago by dgoulet

Reviewer: teordgoulet

comment:4 Changed 2 months ago by dgoulet

Status: needs_reviewneeds_revision

Seems to be an issue with one of the fixes. I'm actually confused how our unit tests didn't explode there...

comment:5 Changed 2 months ago by nickm

Status: needs_revisionneeds_review

I think that it's actually okay; I've tried to explain why on the patch. Let me know if you buy my reasoning :)

comment:6 in reply to:  5 Changed 2 months ago by dgoulet

Keywords: asn-merge added
Status: needs_reviewmerge_ready

Replying to nickm:

I think that it's actually okay; I've tried to explain why on the patch. Let me know if you buy my reasoning :)

Oh my yes... I must have been brain dead when making that comment lol...

ACK!

comment:7 Changed 2 months ago by nickm

No worries; I would rather have false positives about bugs than false negatives. :)

comment:8 Changed 2 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.