Opened 3 weeks ago

Last modified 7 days ago

#31039 needs_revision task

Review proposal 306: IPv6 "Happy Eyeballs" for Tor clients

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, prop299
Cc: neel Actual Points:
Parent ID: #29801 Points:
Reviewer: dgoulet, teor Sponsor:

Description

Hi review assigners,

Please assign a network team member to review proposal 306: IPv6 "Happy Eyeballs" for Tor clients

Here is the pull request:
https://github.com/torproject/torspec/pull/86

Here is the mailing list thread, and my initial review:
https://lists.torproject.org/pipermail/tor-dev/2019-June/013907.html

Neel has pushed my suggested changes as fixups.

Child Tickets

Change History (4)

comment:1 Changed 2 weeks ago by teor

Reviewer: dgoulet

It looks like dgoulet has the connection, circuit, and IPv6 knowledge needed to review this proposal.

comment:2 Changed 7 days ago by teor

Status: assignedneeds_review

Neel has submitted the latest version of his proposal to the tor-dev mailing list. Here is my next review:

I have some overall comments on the proposal:

  1. The proposal is very large now. Let's add an intro section that splits the changes into:
    • initial feasability testing
    • minimum viable product
    • parameter tuning
    • optional features, and how we will know if we need them
  2. Bridges can't be configured with an IPv4 and an IPv6 address in tor, because tor only accepts one IP address per bridge. Let's be clear that bridges are out of scope. (Tor already attempts to connect to all? its configured bridges.)
  3. Each revision of this proposal has added text. Is there any text that is redundant or not useful. Can we make it shorter?

comment:3 Changed 7 days ago by teor

Owner: teor deleted
Status: needs_reviewassigned

comment:4 Changed 7 days ago by teor

Reviewer: dgouletdgoulet, teor
Status: assignedneeds_revision

I asked Neel for the revisions on tor-dev

Note: See TracTickets for help on using tickets.