Tor Browser doesnt delete cookies after closing browser if not in Private Browsing Mode (PBM)

I enabled "Remember history" in options. But i cant select "Delete cookies when closing Tor browser". It reverts back to "until they expire". It was working perfectly before 8.5.2.

Trac:
Username: justforlgs

added TorBrowserTeam201907R component::applications/tor browser owner::tbb-team priority::medium reporter::justforlgs resolution::fixed severity::normal status::closed tbb-regression type::defect labels

You mean 8.5.1 is the last version that worked for you? I am asking as 8.5.2 and 8.5.3 were emergency releases fixing serious security vulnerabilities and shipped with an updated NoScript version. I would not expect your bug out of those changes.

However, I'd expect that's due to the fix for #30565 (moved). Alex, I guess we could just omit setting network.cookie.lifetimePolicy in case the user leaves PBM? That pref value is not critical for "remember history"-mode.

Trac:
Cc: N/A to acat
Summary: Tor Browser doesnt delete cookies after closing browser to Tor Browser doesnt delete cookies after closing browser if not in Private Browsing Mode (PBM)
Keywords: cookie, settings deleted, tbb-regression added
Status: new to needs_information

Yes, I think we can remove that from the pref syncing. I also took a look at browser.download.manager.retention and I don't see any browser code using that preference, so I think we can also remove that one.

Patch: https://github.com/acatarineu/torbutton/commit/31041

Trac:
Status: needs_information to needs_review

Trac:
Keywords: tbb-regression deleted, tbb-regression TorBrowserTeam201907R added

Thanks. Merged to master (commit a13b6c870afa18ac1c7747aa928f89b5706a9f44) and cherry-picked to maint-2.1 (commit 4cec079c058d5756a47f9d661b7aea7a95d31076).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#31041 (closed)