Opened 6 months ago

Closed 6 months ago

#31041 closed defect (fixed)

Tor Browser doesnt delete cookies after closing browser if not in Private Browsing Mode (PBM)

Reported by: justforlgs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-regression TorBrowserTeam201907R
Cc: acat Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I enabled "Remember history" in options. But i cant select "Delete cookies when closing Tor browser". It reverts back to "until they expire". It was working perfectly before 8.5.2.

Child Tickets

Change History (4)

comment:1 Changed 6 months ago by gk

Cc: acat added
Keywords: tbb-regression added; cookie settings removed
Status: newneeds_information
Summary: Tor Browser doesnt delete cookies after closing browserTor Browser doesnt delete cookies after closing browser if not in Private Browsing Mode (PBM)

You mean 8.5.1 is the last version that worked for you? I am asking as 8.5.2 and 8.5.3 were emergency releases fixing serious security vulnerabilities and shipped with an updated NoScript version. I would not expect your bug out of those changes.

However, I'd expect that's due to the fix for #30565. Alex, I guess we could just omit setting network.cookie.lifetimePolicy in case the user leaves PBM? That pref value is not critical for "remember history"-mode.

comment:2 Changed 6 months ago by acat

Status: needs_informationneeds_review

Yes, I think we can remove that from the pref syncing. I also took a look at browser.download.manager.retention and I don't see any browser code using that preference, so I think we can also remove that one.

Patch: https://github.com/acatarineu/torbutton/commit/31041

comment:3 Changed 6 months ago by acat

Keywords: TorBrowserTeam201907R added

comment:4 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to master (commit a13b6c870afa18ac1c7747aa928f89b5706a9f44) and cherry-picked to maint-2.1 (commit 4cec079c058d5756a47f9d661b7aea7a95d31076).

Note: See TracTickets for help on using tickets.