Opened 4 months ago

Last modified 16 hours ago

#31043 needs_review defect

Separate VPN Classes into their own module

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201910R
Cc: gk, sysrqb, hans@… Actual Points:
Parent ID: #32069 Points:
Reviewer: Sponsor:

Description

The VPN and TorService code isn't correctly layered. It has some interdependence.

By breaking out the code, it should be easier to maintain. Its also easier to strip out the VPN for Tor Browser, while maintaining it for Orbot.

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by sisbell

Status: newneeds_review

comment:2 Changed 6 weeks ago by eighthave

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

comment:3 Changed 6 weeks ago by eighthave

Cc: hans@… added

comment:4 Changed 3 days ago by sisbell

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201906 removed
Parent ID: #31042#32069

comment:5 in reply to:  2 Changed 41 hours ago by sisbell

Replying to eighthave:

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

VPN is not needed for Tor Browser, its just moving out the VPN code so that we can make it an independent module that needn't be built as part of the tor browser build.

comment:6 Changed 26 hours ago by gk

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

comment:7 Changed 26 hours ago by gk

Ah, nvm regarding my first question, I am seeing comment:4 now (the other part holds, though).

comment:8 in reply to:  6 Changed 16 hours ago by sisbell

It looks like we should hold off until the work is done in the new tor service. There are a bunch more changes in Orbot since this time so I suspect that latest version of Orbot wouldn't be compatible with these changes (although tor-browser would be compatible).

Replying to gk:

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

Note: See TracTickets for help on using tickets.