Separate VPN Classes into their own module

The VPN and TorService code isn't correctly layered. It has some interdependence.

By breaking out the code, it should be easier to maintain. Its also easier to strip out the VPN for Tor Browser, while maintaining it for Orbot.

Trac:
Parent Ticket: #32069 (moved)

added TorBrowserTeam202006 component::applications/tor browser owner::tbb-team parent::32069 points::2 priority::medium severity::normal status::needs-revision type::defect labels

Changes: https://github.com/sisbell/tor-android-service/commits/0628

Trac:
Status: new to needs_review

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

Trac:
Cc: gk, sysrqb to gk, sysrqb, hans@guardianproject.info

https://github.com/sisbell/tor-android-service/commit/03dc6cd426eba5ce43d800356e92a5e89cb65161

Trac:
Parent: #31042 (moved) to #32069 (moved)
Keywords: TorBrowserTeam201906 deleted, TorBrowserTeam201910 added

Replying to eighthave:

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

VPN is not needed for Tor Browser, its just moving out the VPN code so that we can make it an independent module that needn't be built as part of the tor browser build.

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

Trac:
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R added

Ah, nvm regarding my first question, I am seeing comment:4 now (the other part holds, though).

It looks like we should hold off until the work is done in the new tor service. There are a bunch more changes in Orbot since this time so I suspect that latest version of Orbot wouldn't be compatible with these changes (although tor-browser would be compatible).

Replying to gk:

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

Replying to sisbell:

It looks like we should hold off until the work is done in the new tor service. There are a bunch more changes in Orbot since this time so I suspect that latest version of Orbot wouldn't be compatible with these changes (although tor-browser would be compatible).

Works for me. Removing the review keyword and setting the ticket into needs_revision.

Replying to gk:

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201910R deleted, TorBrowserTeam201910 added

FYI, I have native TorService integrated in Orbot at a crude level, so once I push that somewhere public, you'll be able to see the scope of the changes I'm making. That will happen this week. I'll be upstreaming the streamlining changes first.

I just pushed the rough work to my dev fork's master branch. This is not buildable yet, except on my machine, but I'll keep updating it there as I get things nailed down. https://gitlab.com/eighthave/orbot/tree/master

Also, this has a couple small steps towards separating out the VPN code: https://github.com/guardianproject/orbot/pull/277

Where is the org.torproject.jni.TorService class located? Is this in a different repo?

Replying to eighthave:

I just pushed the rough work to my dev fork's master branch. This is not buildable yet, except on my machine, but I'll keep updating it there as I get things nailed down. https://gitlab.com/eighthave/orbot/tree/master

Also, this has a couple small steps towards separating out the VPN code: https://github.com/guardianproject/orbot/pull/277

Yeah, there are two other repos:

• tor-android-binary from my fork: https://gitlab.com/eighthave/tor-android.git
• jni-api branch from my fork: https://gitlab.com/eighthave/tor.git

Moving tickets to November 2019

Trac:
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201911 added

Trac:
Points: N/A to 2

Moving tickets to December

Trac:
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201912 added

Moving tickets to January

Trac:
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam202001 added

Moving tickets to February

Trac:
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam202002 added

Deferring until June 2020

Trac:
Keywords: TorBrowserTeam202002 deleted, TorBrowserTeam202006 added

changed time estimate to 16h

mentioned in issue #32069 (moved)