Opened 7 months ago

Last modified 7 weeks ago

#31043 needs_revision defect

Separate VPN Classes into their own module

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam202001
Cc: gk, sysrqb, hans@… Actual Points:
Parent ID: #32069 Points: 2
Reviewer: Sponsor:

Description

The VPN and TorService code isn't correctly layered. It has some interdependence.

By breaking out the code, it should be easier to maintain. Its also easier to strip out the VPN for Tor Browser, while maintaining it for Orbot.

Child Tickets

Change History (17)

comment:1 Changed 7 months ago by sisbell

Status: newneeds_review

comment:2 Changed 5 months ago by eighthave

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

comment:3 Changed 5 months ago by eighthave

Cc: hans@… added

comment:4 Changed 3 months ago by sisbell

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201906 removed
Parent ID: #31042#32069

comment:5 in reply to:  2 Changed 3 months ago by sisbell

Replying to eighthave:

Does Tor Browser need anything from the VPN side? Or is it just there as a remnant from ripping the code out of Orbot?

VPN is not needed for Tor Browser, its just moving out the VPN code so that we can make it an independent module that needn't be built as part of the tor browser build.

comment:6 Changed 3 months ago by gk

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

comment:7 Changed 3 months ago by gk

Ah, nvm regarding my first question, I am seeing comment:4 now (the other part holds, though).

comment:8 in reply to:  6 ; Changed 3 months ago by sisbell

It looks like we should hold off until the work is done in the new tor service. There are a bunch more changes in Orbot since this time so I suspect that latest version of Orbot wouldn't be compatible with these changes (although tor-browser would be compatible).

Replying to gk:

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

comment:9 in reply to:  8 Changed 3 months ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed
Status: needs_reviewneeds_revision

Replying to sisbell:

It looks like we should hold off until the work is done in the new tor service. There are a bunch more changes in Orbot since this time so I suspect that latest version of Orbot wouldn't be compatible with these changes (although tor-browser would be compatible).

Works for me. Removing the review keyword and setting the ticket into needs_revision.

Replying to gk:

sisbell: I guess the patch in comment:1 is still up-to-date? And, please add the respective review keyword to your tickets when done otherwise we might easily lose track of them. It's TorBrowserTeamYYYYMMR.

comment:10 Changed 3 months ago by eighthave

FYI, I have native TorService integrated in Orbot at a crude level, so once I push that somewhere public, you'll be able to see the scope of the changes I'm making. That will happen this week. I'll be upstreaming the streamlining changes first.

comment:11 Changed 3 months ago by eighthave

I just pushed the rough work to my dev fork's master branch. This is not buildable yet, except on my machine, but I'll keep updating it there as I get things nailed down.
https://gitlab.com/eighthave/orbot/tree/master

Also, this has a couple small steps towards separating out the VPN code:
https://github.com/guardianproject/orbot/pull/277

comment:12 in reply to:  11 Changed 3 months ago by sisbell

Where is the org.torproject.jni.TorService class located? Is this in a different repo?

Replying to eighthave:

I just pushed the rough work to my dev fork's master branch. This is not buildable yet, except on my machine, but I'll keep updating it there as I get things nailed down.
https://gitlab.com/eighthave/orbot/tree/master

Also, this has a couple small steps towards separating out the VPN code:
https://github.com/guardianproject/orbot/pull/277

comment:13 Changed 3 months ago by eighthave

Yeah, there are two other repos:

comment:14 Changed 3 months ago by pili

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201910 removed

Moving tickets to November 2019

comment:15 Changed 3 months ago by pili

Points: 2

comment:16 Changed 7 weeks ago by pili

Keywords: TorBrowserTeam201912 added; TorBrowserTeam201911 removed

Moving tickets to December

comment:17 Changed 7 weeks ago by pili

Keywords: TorBrowserTeam202001 added; TorBrowserTeam201912 removed

Moving tickets to January

Note: See TracTickets for help on using tickets.