Opened 16 months ago

Last modified 4 months ago

#31062 new defect

token bucket: Improve library to handle under/overflow and clock jump

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: token-bucket, 043-deferred, 044-deferred
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor: Sponsor27-can


The DoS subsystem implements a very simple token bucket but has a lot of safeguards against under/overflows and clock jump.

We should take those, move them into the token-bucket implementation and then make the DoS subsystem use it.

This is quite important to not wait too long on it because of #15516 will soon be used extensively using the generic token bucket.

Child Tickets

Change History (4)

comment:1 Changed 13 months ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

comment:2 Changed 9 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:3 Changed 9 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final

comment:4 Changed 4 months ago by nickm

Keywords: 044-deferred added
Milestone: Tor: 0.4.4.x-finalTor: unspecified

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Note: See TracTickets for help on using tickets.