Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#31067 closed defect (fixed)

Warn the user when WebRTC is detected as being disabled in the browser in the Snowflake WebExtension

Reported by: cypherpunks Owned by: arlolra
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: snowflake-webextension
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: cohosh Sponsor:

Description

Right now only a snowflake is displayed (without the text), so it doesn't give any impression to the user that something is not going right

Child Tickets

Change History (7)

comment:1 Changed 3 months ago by arlolra

Owner: set to arlolra
Status: newassigned

comment:2 Changed 3 months ago by arlolra

Status: assignedneeds_review

Here's a patch for this,
https://github.com/keroserene/snowflake/commit/c6b766546c13c4b184fe44fa6e4907b303c36174

Might want to wait on resolving #30934 since the popup's onMessage handler could use some refactoring.

comment:3 Changed 3 months ago by cohosh

Reviewer: cohosh
Status: needs_reviewmerge_ready

This change looks good to me. I tried it out on Firefox after setting media.peerconnection.enabled to false in about:config and it worked. I agree on waiting until #30934 is resolved to see if there's a better way to structure the onMessage callback.

comment:4 Changed 3 months ago by arlolra

Status: merge_readyneeds_review

This change looks good to me.

Merged as,
https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=095f4a0510213e4d61993b91d93d07e4194a296e

I agree on waiting until #30934 is resolved to see if there's a better way to structure the onMessage callback.

Here's a proposal patch to clean things up,
https://github.com/keroserene/snowflake/commit/b9c39e7f1eecda02e1891d3e3a8eba3c3bfb69cc

comment:5 Changed 3 months ago by cohosh

Status: needs_reviewmerge_ready

Wow this is a lot cleaner, thanks for doing this. It looks good to me!

comment:6 Changed 3 months ago by arlolra

Resolution: fixed
Status: merge_readyclosed

Wow this is a lot cleaner, thanks for doing this. It looks good to me!

It went in as,
https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=453bf0611cadfc9f85240d3424b04a638b4604f3

Note: See TracTickets for help on using tickets.