Opened 11 months ago

Last modified 4 months ago

#31074 new defect

Use tor_queue.h macros in config_line_t

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactor, technical-debt
Cc: catalyst Actual Points:
Parent ID: #7479 Points: 1
Reviewer: Sponsor:

Description

The config_line_t linked list could be refactored to use the TOR_SLIST macros in tor_queue.h

Child Tickets

Change History (7)

comment:1 Changed 11 months ago by catalyst

Cc: catalyst added

comment:2 in reply to:  description Changed 11 months ago by catalyst

Replying to nickm:

The config_line_t linked list could be refactored to use the TOR_SLIST macros in tor_queue.h

I would suggest using the TOR_SIMPLEQ macros instead. There are places where it would be helpful to have an O(1) append. (config_get_lines_aux() explicitly works around this by temporarily creating a list_last pointer and mentions O(n2) performance as an issue.)

comment:3 Changed 11 months ago by catalyst

Keywords: technical-debt added; teschnical-debt removed

Fix keyword typo.

comment:4 Changed 10 months ago by gaba

Keywords: network-team-roadmap-september added

comment:5 Changed 4 months ago by gaba

Keywords: network-team-roadmap-september removed
Sponsor: Sponsor31-can

Sponsor closed. Remove from roadmap.

comment:6 Changed 4 months ago by catalyst

Parent ID: #31179

comment:7 Changed 4 months ago by catalyst

Parent ID: #31179#7479
Note: See TracTickets for help on using tickets.