Opened 8 weeks ago

Last modified 5 weeks ago

#31074 new defect

Use tor_queue.h macros in config_line_t

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactor technical-debt network-team-roadmap-september
Cc: catalyst Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: Sponsor31-can

Description

The config_line_t linked list could be refactored to use the TOR_SLIST macros in tor_queue.h

Child Tickets

Change History (4)

comment:1 Changed 8 weeks ago by catalyst

Cc: catalyst added

comment:2 in reply to:  description Changed 7 weeks ago by catalyst

Replying to nickm:

The config_line_t linked list could be refactored to use the TOR_SLIST macros in tor_queue.h

I would suggest using the TOR_SIMPLEQ macros instead. There are places where it would be helpful to have an O(1) append. (config_get_lines_aux() explicitly works around this by temporarily creating a list_last pointer and mentions O(n2) performance as an issue.)

comment:3 Changed 7 weeks ago by catalyst

Keywords: technical-debt added; teschnical-debt removed

Fix keyword typo.

comment:4 Changed 5 weeks ago by gaba

Keywords: network-team-roadmap-september added
Note: See TracTickets for help on using tickets.