Opened 5 months ago

Last modified 2 months ago

#31075 new defect

Consider dropping browser patch for 26353

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-linkability
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

I think the patch for #26353 is not strictly needed, since the speculative connections are blocked when a proxy is configured (here: https://github.com/mozilla/gecko-dev/blob/esr60/netwerk/base/nsIOService.cpp#L1621, and same in 68). So while the speculative requests can be seen in torbutton domain-isolator, they should be dropped before they reach tor client.

I tested by changing the torbutton code to not put all these to the --unknown-- catch-all circuit so that they could be tracked, and while I can see these in logs coming from the domain isolator, there are no corresponding open circuits in the Torbutton INFO: controlPort << getinfo circuit-status logs.

It's always possible that this might change in the future (according to the comments in that file, the reason why the speculative connections are not performed when there is a proxy do not seem so strong). So we might still want the current patch for #26353 just in case, I'm not sure.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by gk

Keywords: tbb-linkability added

comment:2 Changed 5 months ago by gk

Yes, I had done the same analysis in #18762 and see #16324, too. So, I am fine with dropping this patch given that we did not fix the other ones or marked them as WONTFIX. *But*, in general it seems to me we want to fix this class of FPI issues as, as you said, it's not clear the status quo stays as it is. Moreover, FPI should be working for users without a proxy as well. So, having (some) speculative connects not adhering to it is a bug. Getting this right would as well mean we would get rid of the false positives in the Torbutton log which turned out to be quite time-consuming over the time to investigate.

Last edited 5 months ago by gk (previous) (diff)

comment:3 Changed 5 months ago by acat

I think you mean #18762 :)

In the uplift meeting tom suggested trying to enable the speculative connections when a proxy is set, and make them obey FPI, which I think is a good idea. I'm not sure how much of FPI applies to speculative connections (cookies, ssl sessions...?). But I think it's worth investigating and filing a bug in bugzilla. Then also a different one for enabling speculative connections when proxy is configured (which would depend on the FPI one)?

comment:4 in reply to:  3 Changed 5 months ago by gk

Replying to acat:

I think you mean #18762 :)

Yes!

In the uplift meeting tom suggested trying to enable the speculative connections when a proxy is set, and make them obey FPI, which I think is a good idea. I'm not sure how much of FPI applies to speculative connections (cookies, ssl sessions...?). But I think it's worth investigating and filing a bug in bugzilla. Then also a different one for enabling speculative connections when proxy is configured (which would depend on the FPI one)?

I agree. Sounds like good steps forward to me.

comment:5 Changed 4 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:6 Changed 2 months ago by gk

Keywords: ff68-esr removed

Nothing for the ESR68 switch.

Note: See TracTickets for help on using tickets.