Opened 3 months ago

Closed 3 months ago

#31113 closed enhancement (implemented)

Circuitpadding updated comments

Reported by: pulls Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: 0.4.1.3-alpha
Severity: Normal Keywords:
Cc: asn, mikeperry, gaba Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Went over src/core/or/circuitpadding.{h,c} and updated a number of code comments. Most of them minor enhancements, but one defect: clarifying the purpose of event CIRCPAD_EVENT_LENGTH_COUNT. PR here: https://github.com/torproject/tor/pull/1169.

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by teor

Status: newneeds_review

comment:2 Changed 3 months ago by nickm

Milestone: Tor: 0.4.1.x-final

comment:3 Changed 3 months ago by asn

A bunch of trailing whitespace and other than that this is gold. We should make an updated branch that squashes everything and cleans up the trailing whitespace.

comment:4 Changed 3 months ago by nickm

Keywords: 041-can added

comment:5 Changed 3 months ago by nickm

Status: needs_reviewneeds_revision

comment:6 Changed 3 months ago by asn

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final

I added a changes file and fixed the trailing whitespace over here: https://github.com/torproject/tor/pull/1186

I'm moving this to 042 since it's just documentation improvements.

comment:7 Changed 3 months ago by asn

Status: needs_revisionmerge_ready

comment:8 Changed 3 months ago by nickm

Keywords: 041-can removed
Resolution: implemented
Status: merge_readyclosed

LGTM too; merged to master.

Note: See TracTickets for help on using tickets.