#31134 closed enhancement (fixed)

Reenable Graphite for font rendering

Reported by: gk Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, TorBrowserTeam201912R, GeorgKoppen201912
Cc: Actual Points: 0.1
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

We disabled using Graphite for font rendering (after trying to reenable it) back in #21726 for security reasons. Things have settled down it seems. Thus, we should reenable it and put it back on the security slider this time.

Child Tickets

Change History (6)

comment:1 Changed 15 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:2 Changed 10 months ago by sysrqb

Keywords: TorBrowserTeam202002 added

Yep. There haven't been any critical bugs recently.

comment:3 Changed 10 months ago by gk

Actual Points: 0.1
Keywords: TorBrowserTeam201912R added; TorBrowserTeam202002 removed
Status: newneeds_review

I have actually patches as this helps with my RLBox work as well: bug_31134 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_31134&id=ff6bb6affa58dace225ea8b76d7c8d6597ad3be1) in my Torbutton repo and bug_31134 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_31134&id=4b45c970c7391af1d3a0b2e566d68247d34b6190) in my tor-browser one. I think we don't need to adapt the text for the security settings with this change.

This works for me on Linux and Android.

comment:4 Changed 10 months ago by gk

Keywords: GeorgKoppen201912 added
Owner: changed from tbb-team to gk
Status: needs_reviewassigned

comment:5 Changed 10 months ago by gk

Status: assignedneeds_review

comment:6 Changed 10 months ago by sysrqb

Resolution: fixed
Status: needs_reviewclosed

That looks good to me. Enabled on Standard, and disabled on Safer and Safest. The torbutton change was merged as commit ff6bb6affa58dace225ea8b76d7c8d6597ad3be1. The tor-browser change was merged as commit 4b45c970c7391af1d3a0b2e566d68247d34b6190.

Note: See TracTickets for help on using tickets.