Opened 3 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#31141 closed defect (fixed)

font.system.whitelist value typo?

Reported by: Thorin Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-fingerprinting-fonts, TorBrowserTeam201908R, GeorgKoppen201908
Cc: Actual Points:
Parent ID: #18097 Points:
Reviewer: Sponsor:

Description

On windows (haven't checked Mac or Linux yet) the font.system.whitelist contains

..., Microsoft JhengHei, Microsoft JengHei UI, ...

In looking at some font lists used for enumeration, I don't see the second font spelt this way - e.g Arthur's ordered list at https://github.com/arthuredelstein/tordemos/blob/gh-pages/fontList.txt#L477 . Even a google search for the one used in the whitelist corrects itself to Showing results for Microsoft JhengHei UI

Just checking in with the font experts to see if this is a typo

  • JengHei UI <- used in whitelist
  • JhengHei UI <- used everywhere else I looked so far

Child Tickets

Change History (12)

comment:1 Changed 3 months ago by gk

Keywords: TorBrowserTeam201907 added
Parent ID: #18097

Hm, I guess you are right. Nice catch! Let this get fixed for the next release.

comment:3 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving more tickets to August

comment:4 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201908R GeorgKoppen201908 added; TorBrowserTeam201908 removed
Status: newneeds_review

comment:5 Changed 8 weeks ago by Thorin

Any chance of adding EmojiOne Mozilla ?

comment:6 Changed 7 weeks ago by acat

The patch looks good to me.

comment:7 in reply to:  6 Changed 7 weeks ago by gk

Replying to acat:

The patch looks good to me.

Thanks! merged to tor-browser-60.8.0esr-8.5-1 (commit 393eb8915c202736cd22f489724af9fa14dacb2d). I'll leave this open for the alpha branch.

comment:8 Changed 7 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, I cherry-picked the patch onto tor-browser-681.0esr-9.0-1 (commit bd3c6c4beaf4c0ee004c841d8474e26b32925692).

comment:9 in reply to:  5 ; Changed 7 weeks ago by gk

Replying to Thorin:

Any chance of adding EmojiOne Mozilla ?

I think that would be good. Maybe it would even help with #18172 and #20842. Care to write a patch? :)

comment:10 in reply to:  9 Changed 7 weeks ago by Thorin

Replying to gk:

Care to write a patch? :)

Despite my astonishingly good looks, I wouldn't have the faintest idea where to submit it :) That's why you get paid the big bucks <g>

And yes, it makes emoji's all colorful etc (ignore the FP part)

TB: all black and white
TB with EmojiOne Mozilla added to the whitelist (restart req) - all colorful and more detailed

I assume (without re-checking) this is bundled with Linux and Mac as well? I have no idea about Android.

comment:11 Changed 7 weeks ago by cypherpunks

No restart req.
Before: Emoji Support: ~612/2575
After: Emoji Support: ~2341/2575

comment:12 in reply to:  11 Changed 7 weeks ago by Thorin

Replying to cypherpunks:

No restart req.

Oooh. I could have sworn a restart was required. Maybe bundled fonts is handled differently to reading/allowing system fonts - or it differs per OS? Not that it really matters. Thanks for the info :)

Note: See TracTickets for help on using tickets.