r17b! Not even r17c! It is a minimum supported version! Not something you should use.
Recommended version is r20. We need at least -fstack-protector-strong from r18b, see https://github.com/android-ndk/ndk/wiki/Changelog-r18
r17b! Not even r17c! It is a minimum supported version! Not something you should use.
Recommended version is r20. We need at least -fstack-protector-strong from r18b, see https://github.com/android-ndk/ndk/wiki/Changelog-r18
The approach is follow the firefox toolchain and versions as precisely as possible so as to not introduce unexpected build results or runtime behavior. This means there will be some lag in version updates for the tools.
Looks good to me apart from one trailing whitespace. I removed that one myself to save us a roundtrip. Applied to master (commit 576c12b5e461df957731a7d4583d84a8e716ddaf).
Trac: Status: needs_review to closed Resolution: N/Ato fixed