Opened 13 months ago

Closed 12 months ago

Last modified 12 months ago

#31173 closed defect (fixed)

Update android-toolchain project to match firefox

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, tbb-9.0-must-nightly, TorBrowserTeam201908R
Cc: boklm, sisbell, gk Actual Points:
Parent ID: #30324 Points:
Reviewer: Sponsor: Sponsor44-can

Description

This includes ndk 17 and android build tools 27.

Child Tickets

Change History (12)

comment:2 Changed 13 months ago by sisbell

Status: newneeds_review

comment:3 Changed 13 months ago by sisbell

Cc: gk added

comment:4 Changed 13 months ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201907 removed

comment:5 Changed 13 months ago by cypherpunks

r17b! Not even r17c! It is a minimum supported version! Not something you should use.
Recommended version is r20. We need at least -fstack-protector-strong from r18b, see https://github.com/android-ndk/ndk/wiki/Changelog-r18

comment:6 Changed 13 months ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:7 in reply to:  5 Changed 13 months ago by sisbell

Replying to cypherpunks:

r17b! Not even r17c! It is a minimum supported version! Not something you should use.
Recommended version is r20. We need at least -fstack-protector-strong from r18b, see https://github.com/android-ndk/ndk/wiki/Changelog-r18

The approach is follow the firefox toolchain and versions as precisely as possible so as to not introduce unexpected build results or runtime behavior. This means there will be some lag in version updates for the tools.

comment:8 Changed 13 months ago by cypherpunks

Then it's time to ask Mozilla to update, no?

comment:9 Changed 13 months ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907R removed

No July any longer.

comment:10 Changed 12 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:11 Changed 12 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me apart from one trailing whitespace. I removed that one myself to save us a roundtrip. Applied to master (commit 576c12b5e461df957731a7d4583d84a8e716ddaf).

comment:12 Changed 12 months ago by cypherpunks

What looks good for you? That Mozilla ignores "your project automatically uses a default version of the build tools that the plugin specifies"?

Note: See TracTickets for help on using tickets.