Opened 3 months ago

Closed 2 months ago

#31175 closed enhancement (fixed)

Teach practracker to apply separate rules for C headers

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-august dgoulet-merge
Cc: nickm Actual Points: .1
Parent ID: #29746 Points: 1
Reviewer: asn Sponsor: Sponsor31-can

Description

We might want to impose stricter limits for length and includes on header files than we do on C files.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by nickm

Sponsor: Sponsor31-can

comment:2 Changed 3 months ago by gaba

Cc: nickm added
Keywords: network-team-roadmap-august added

comment:3 Changed 2 months ago by nickm

See branch ticket31175 with PR in https://github.com/torproject/tor/pull/1200

I've conservatively chosen 500 as a maximum header length and 15 as maximum header includes for now; we can crank that limit down later on if we want.

comment:4 Changed 2 months ago by nickm

Status: assignedneeds_review

comment:5 Changed 2 months ago by nickm

Actual Points: .1

comment:6 Changed 2 months ago by asn

Reviewer: asn

comment:7 Changed 2 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:8 Changed 2 months ago by nickm

Keywords: dgoulet-merge added

comment:9 Changed 2 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

So this doesn't merge cleanly in master due to exceptions.txt of practracker... I fixed the conflict, was very small thing. See extra commit: 81e37b81f1b0329a312a2647cd3601f112d6657b

Merged!

Note: See TracTickets for help on using tickets.