Remove easy deprecated options in 0.4.4

We have accumulated a handful of deprecated options; Teor intends to remove (some of?) them in 0.4.3.

changed milestone to %Tor: unspecified

added 043-can 044-deferred actualpoints::.1 component::core tor/tor milestone::Tor: unspecified owner::nickm points::2 priority::medium severity::normal status::needs-revision type::task labels

Trac:
Keywords: N/A deleted, network-team-roadmap-november added
Cc: N/A to teor
Owner: teor to N/A
Points: N/A to 2

Sponsor closed. Remove from roadmap.

Trac:
Sponsor: Sponsor31-can to N/A

Trac:
Keywords: network-team-roadmap-november deleted, N/A added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

Trac:
Keywords: N/A deleted, 043-deferred added

Trac:
Owner: N/A to nickm
Status: assigned to accepted
Keywords: 043-deferred deleted, 043-can added

I think we should remove ReachableDirAddresses, HTTPProxy, and HTTPProxyAuthenticator in 0.4.3, and leave other options for later.

In particular, we should leave ClientPreferIPv6DirPort alone, since it will probably get removed anyway during our IPv6 work for Sponsor 55.

see branch ticket31180 with PR at https://github.com/torproject/tor/pull/1688

Trac:
Actualpoints: N/A to .1
Status: accepted to needs_review

Replying to nickm:

I think we should remove ReachableDirAddresses, HTTPProxy, and HTTPProxyAuthenticator in 0.4.3, and leave other options for later.

In particular, we should leave ClientPreferIPv6DirPort alone, since it will probably get removed anyway during our IPv6 work for Sponsor 55.

Sponsor 55 is a relay-focused grant, so client changes are out of scope.

I don't plan on removing ClientPreferIPv6DirPort as part of Sponsor 55, so you should feel free to remove it now.

Trac:
Status: needs_review to needs_revision

Okay, I'll take a look at that. I might defer it anyway, since it seems significantly more complex than the other options.

Also it appears that travis is rejecting the branch, so I should figure that out too.

Replying to nickm:

Okay, I'll take a look at that. I might defer it anyway, since it seems significantly more complex than the other options.

That's fair enough. The last time I tried to remove ClientPreferIPv6DirPort, I ended up removing too much code, and quitting part of the way through.

There's a lot of code we could remove once we get rid of it.

I don't think I've got the brainpower to remove ClientPreferIPv6DirPort right now, and I think we've missed the window where it's sensible to try this for 0.4.3. Let's review what we've got in 0.4.4, and maybe open a ticket for removing some more deprecated options if possible.

Trac:
Status: needs_revision to needs_review
Milestone: Tor: 0.4.3.x-final to Tor: 0.4.4.x-final
Summary: Remove deprecated options in 0.4.3. to Remove easy deprecated options in 0.4.4

Oh. But travis is still failing. :p

Trac:
Status: needs_review to needs_revision

It looks like my fix is wrong: it has chutney failing, which should not have happened for this patch. I need to review this much more closely.

Replying to nickm:

I don't think I've got the brainpower to remove ClientPreferIPv6DirPort right now, and I think we've missed the window where it's sensible to try this for 0.4.3. Let's review what we've got in 0.4.4, and maybe open a ticket for removing some more deprecated options if possible.

I agree, it probably needs to happen early in 0.4.4. Or at the very least, before we do the IPv6 client work in proposal 306.

Maybe coccinelle could help reduce the workload? We could get an initial patch by replacing options->ClientPreferIPv6DirPort with 0, and then removing || 0 and similar redundant constructs.

As a second step, we can then simplify or rewrite a bunch of functions, but that doesn't need to happen straight away.

(And now that clients only use ORPorts, their reachability decisions are between one IPv4 ORPort, and up to one IPv6 ORPort, which is a lot simpler. But that could be a third ticket.)

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Trac:
Keywords: N/A deleted, 044-deferred added
Milestone: Tor: 0.4.4.x-final to Tor: unspecified

changed time estimate to 16h

added 48m of time spent

moved to tpo/core/tor#31180 (closed)