Opened 13 months ago

Last modified 2 months ago

#31180 needs_revision task

Remove easy deprecated options in 0.4.4

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 043-can, 044-deferred
Cc: teor Actual Points: .1
Parent ID: Points: 2
Reviewer: Sponsor:

Description

We have accumulated a handful of deprecated options; Teor intends to remove (some of?) them in 0.4.3.

Child Tickets

Change History (15)

comment:1 Changed 13 months ago by gaba

Cc: teor added
Keywords: network-team-roadmap-november added
Owner: teor deleted
Points: 2

comment:2 Changed 7 months ago by gaba

Sponsor: Sponsor31-can

Sponsor closed. Remove from roadmap.

comment:3 Changed 7 months ago by gaba

Keywords: network-team-roadmap-november removed

comment:4 Changed 7 months ago by nickm

Keywords: 043-deferred added

All 0.4.3.x tickets without 043-must, 043-should, or 043-can are about to be deferred.

comment:5 Changed 7 months ago by nickm

Keywords: 043-can added; 043-deferred removed
Owner: set to nickm
Status: assignedaccepted

comment:6 Changed 7 months ago by nickm

I think we should remove ReachableDirAddresses, HTTPProxy, and HTTPProxyAuthenticator in 0.4.3, and leave other options for later.

In particular, we should leave ClientPreferIPv6DirPort alone, since it will probably get removed anyway during our IPv6 work for Sponsor 55.

comment:7 Changed 7 months ago by nickm

Actual Points: .1
Status: acceptedneeds_review

see branch ticket31180 with PR at https://github.com/torproject/tor/pull/1688

comment:8 in reply to:  6 Changed 7 months ago by teor

Status: needs_reviewneeds_revision

Replying to nickm:

I think we should remove ReachableDirAddresses, HTTPProxy, and HTTPProxyAuthenticator in 0.4.3, and leave other options for later.

In particular, we should leave ClientPreferIPv6DirPort alone, since it will probably get removed anyway during our IPv6 work for Sponsor 55.

Sponsor 55 is a relay-focused grant, so client changes are out of scope.

I don't plan on removing ClientPreferIPv6DirPort as part of Sponsor 55, so you should feel free to remove it now.

comment:9 Changed 7 months ago by nickm

Okay, I'll take a look at that. I might defer it anyway, since it seems significantly more complex than the other options.

Also it appears that travis is rejecting the branch, so I should figure that out too.

comment:10 in reply to:  9 Changed 7 months ago by teor

Replying to nickm:

Okay, I'll take a look at that. I might defer it anyway, since it seems significantly more complex than the other options.

That's fair enough. The last time I tried to remove ClientPreferIPv6DirPort, I ended up removing too much code, and quitting part of the way through.

There's a *lot* of code we could remove once we get rid of it.

comment:11 Changed 6 months ago by nickm

Milestone: Tor: 0.4.3.x-finalTor: 0.4.4.x-final
Status: needs_revisionneeds_review
Summary: Remove deprecated options in 0.4.3.Remove easy deprecated options in 0.4.4

I don't think I've got the brainpower to remove ClientPreferIPv6DirPort right now, and I think we've missed the window where it's sensible to try this for 0.4.3. Let's review what we've got in 0.4.4, and maybe open a ticket for removing some more deprecated options if possible.

comment:12 Changed 6 months ago by nickm

Status: needs_reviewneeds_revision

Oh. But travis is still failing. :p

comment:13 Changed 6 months ago by nickm

It looks like my fix is wrong: it has chutney failing, which should not have happened for this patch. I need to review this much more closely.

comment:14 in reply to:  11 Changed 6 months ago by teor

Replying to nickm:

I don't think I've got the brainpower to remove ClientPreferIPv6DirPort right now, and I think we've missed the window where it's sensible to try this for 0.4.3. Let's review what we've got in 0.4.4, and maybe open a ticket for removing some more deprecated options if possible.

I agree, it probably needs to happen early in 0.4.4. Or at the very least, before we do the IPv6 client work in proposal 306.

Maybe coccinelle could help reduce the workload?
We could get an initial patch by replacing options->ClientPreferIPv6DirPort with 0, and then removing || 0 and similar redundant constructs.

As a second step, we can then simplify or rewrite a bunch of functions, but that doesn't need to happen straight away.

(And now that clients only use ORPorts, their reachability decisions are between one IPv4 ORPort, and up to one IPv6 ORPort, which is a lot simpler. But that could be a third ticket.)

comment:15 Changed 2 months ago by nickm

Keywords: 044-deferred added
Milestone: Tor: 0.4.4.x-finalTor: unspecified

Bulk-remove tickets from 0.4.4. Add the 044-deferred label to them.

Note: See TracTickets for help on using tickets.