Opened 6 weeks ago

Closed 3 weeks ago

#31195 closed enhancement (wontfix)

Upgrade CollecTor to Debian buster libraries

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: #31193 Points:
Reviewer: irl Sponsor:

Description

We'll need to upgrade CollecTor to Debian buster libraries, though we should first finish the metrics-base review in #31194.

Child Tickets

Change History (8)

comment:1 Changed 5 weeks ago by karsten

Reviewer: irl
Status: newneeds_review

The metrics-base review in #31194 is done.

Please review commit e65269d in my task-31195 branch.

comment:2 Changed 5 weeks ago by irl

Are we going to have a version change for metrics-lib with the change in dependencies?

comment:3 in reply to:  2 Changed 5 weeks ago by karsten

Replying to irl:

Are we going to have a version change for metrics-lib with the change in dependencies?

Great question! I had been thinking about this, too.

I believe that we don't have to put out a new metrics-lib release first and depend on that. We're using metrics-lib-2.6.2-thin.jar in CollecTor which doesn't contain any third-party libraries.

The reason why I didn't start the process of putting out a new metrics-lib release is that we should probably include the new Checkstyle version in that. Otherwise we'd have to put out a new release now and another one in a few days or weeks, depending on how long #25217 takes.

If you'd prefer putting out a metrics-lib release first, should we then focus on #25217 first and pause this one for the moment?

comment:4 Changed 5 weeks ago by irl

I don't think we need to. We just need to say in the CollecTor changelog which libraries have changed when we do a release.

I think that #25217 is resolved, we just need to watch out for the rebuilt jar to drop in once it appears.

comment:5 Changed 5 weeks ago by irl

Status: needs_reviewmerge_ready

comment:6 Changed 5 weeks ago by karsten

Resolution: fixed
Status: merge_readyclosed

Merged, together with a couple more new dependencies required for Checkstyle. Closing. Thanks!

comment:7 Changed 4 weeks ago by karsten

Resolution: fixed
Status: closedreopened

As discussed on Thursday, I reverted these changes, because it turned out that updating dependencies manually doesn't scale anymore. We'll have to find another solution for all our code bases.

comment:8 Changed 3 weeks ago by karsten

Resolution: wontfix
Status: reopenedclosed

Closing all tickets related to Debian buster libraries, now that we're using Apache Ivy for external dependency management.

Note: See TracTickets for help on using tickets.