Opened 3 months ago

Closed 3 months ago

#31207 closed defect (fixed)

Space out first connection_edge_process_relay_cell() line in circuit_receive_relay_cell()

Reported by: neel Owned by: neel
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: dgoulet-merge
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:

Description

The first if statement containing connection_edge_process_relay_cell() looks like this

      if ((reason=connection_edge_process_relay_cell(cell, circ, conn, NULL))
          < 0) {

Whereas the second looks like this:

      if ((reason = connection_edge_process_relay_cell(cell, circ, conn,
                                                       layer_hint)) < 0) {

We should space out the first

Child Tickets

Change History (10)

comment:1 Changed 3 months ago by neel

Status: assignedneeds_review

comment:2 Changed 3 months ago by nickm

Keywords: backport? added
Milestone: Tor: 0.4.2.x-final

comment:3 Changed 3 months ago by dgoulet

Reviewer: teor

comment:4 Changed 3 months ago by teor

Reviewer: teornickm

comment:5 Changed 3 months ago by nickm

Status: needs_reviewmerge_ready

This is fine. I'd also take a patch to extract the assignment entirely, since using assignment in this way is error-prone.

comment:6 in reply to:  5 Changed 3 months ago by neel

Replying to nickm:

This is fine. I'd also take a patch to extract the assignment entirely, since using assignment in this way is error-prone.

I created a ticket for this in #31366.

comment:7 Changed 3 months ago by dgoulet

Keywords: dgoulet-merge added

comment:8 Changed 3 months ago by teor

Keywords: backport? removed

This seems to just be formatting/refactoring, so I'm not sure if it's worth a backport?

comment:9 Changed 3 months ago by nickm

agreed

comment:10 Changed 3 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged! No backport.

Note: See TracTickets for help on using tickets.