Opened 8 years ago

Closed 8 years ago

#3121 closed defect (wontfix)

Do we need to check https URLs for rewrites?

Reported by: pde Owned by: pde
Priority: Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Seems that we might be doing so, but it would be a performance win not to.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by nickm

Component: - Select a componentEFF-HTTPS Everywhere
Owner: set to pde

comment:2 Changed 8 years ago by pde

Status: newaccepted

The optimal fix for this is going to be slightly complicated by "moot rule" detection in the context-menu branch in my remote, which should be landing in master soon. We will give the user a menu to see which rules are active in the current page, and those will include rules that /would/ have been active if required, but everything was https anyway.

Despite this, some performance improvement should be possible here.

comment:3 Changed 8 years ago by pde

Resolution: wontfix
Status: acceptedclosed

The context-menu branch has landed in master, and the way it turned out it seems like it will be hard to get this kind of performance improvement now, without assuming that a rule is moot based on its <target host> elements rather than checking the actual regular expressions.

The above sounds okay in principle, but it would have the counter-intuitive consequence of (for instance) always showing the user the Google Images rule as moot when they do Google web searches, because both of those rulesets target the same domains.

Note: See TracTickets for help on using tickets.