Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

When you click on the Security Level icon the resulting menu is lower than it should be as compared to other buttons (Downloads, Library, Hamburger Menu, etc). This happens because the dropdown element is parented to the wrong element in the DOM.

added TorBrowserTeam201908R component::applications/tor browser owner::pospeselr priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
Summary: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's 'anchor' to Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

Fixed this and a few other UI polish issues relating to the Security Level toolbar button, details in commit log.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31251

Trac:
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added
Status: assigned to needs_review

I tested it, and works mostly fine, except when you try to move the button via Customize.... Then it stops working for the session, but it works for new windows and also when restarting. Is it because the patch is now caching the button instead of getting it every time?

Some minor issues:

		  classList.add("safest");         

Could you remove the trailing spaces? Also, there are some empty lines with leading spaces, could you remove them too?

The get button() implementation in browser-places.js looks slightly simpler and also works for me, but up to you to keep this one, looks also good (unless this is what is breaking when moving the button around).

openAdvancedSecuritySettings : async function() {

This is not new code, but why async? This should be equivalent to the same function without async and returning Promise.resolve(). Is it because it's required to return a Promise? Otherwise I think we can remove async here.

Trac:
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201907 added
Status: needs_review to needs_revision

Ok I pushed a fixup commit. I'm now deleting the _anchor and _button members from the SecurityLevelButton object when the UI DOM changes.

I don't remember why that function was marked 'async' and I've verified that it now works without it. IIRC there was a bug associated (yep #29554 (moved)) with getting the about:preferences to scroll down to our Security Level settings so perhaps async was an attempt of a work-around for that. Removed.

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31251

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added

Looks good and works for me now.

posepeslr: Could you squash the commits and shorten the summary of your commit message? It's useful to be able to read that in a terminal on one line (for more about that, see: https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).

Trac:
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201908 added
Status: needs_review to needs_revision

squashed into a new branch:

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31251_v2

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: TorBrowserTeam201908 deleted, TorBrowserTeam201908R added

Thanks! Looks good and merged to tor-browser-60.8.0esr-9.0-1 (commit 0bed1d181d0839f058e311c01dbdb263a96270fd).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #31920 (moved)

moved to tpo/applications/tor-browser#31251 (closed)