Opened 3 months ago

Closed 3 months ago

#31254 closed defect (fixed)

Tor Support Portal "How can I verify Tor Browser's signature" has inaccurate instructions that can prevent signature verification of Tor Browser

Reported by: monmire Owned by: ggus
Priority: Medium Milestone:
Component: Webpages/Support Version:
Severity: Normal Keywords: Support Portal instructions can prevent signature verification - issue
Cc: ggus, pili Actual Points:
Parent ID: #31296 Points:
Reviewer: Sponsor:

Description

At https://support.torproject.org/tbb/how-to-verify-signature/,
the subsection macOS and Linux" / For macOS users
presents instructions to mac OS users to run terminal command
gpg --verify ~/Downloads/TorBrowser-8.0.8-osx64_en-US.dmg{.asc,}

On macOS, running that command returns terminal output
gpg: no valid OpenPGP data found.
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.

However, running terminal command
gpg --verify ~/Downloads/{.asc,} TorBrowser-8.0.8-osx64_en-US.dmg
returns terminal output
gpg: Signature made Mon Jul 8 03:56:12 2019 PDT
gpg: using RSA key EB774491D9FF06E2
gpg: Good signature from "Tor Browser Developers (signing key) <torbrowser@torproject.org>"


If we instruct new Tor Browser users, who might become discouraged by the terminal return
gpg: no valid OpenPGP data found.
gpg: the signature could not be verified.
Please remember that the signature file (.sig or .asc)
should be the first file given on the command line.
to instead run terminal command
gpg --verify ~/Downloads/{.asc,} TorBrowser-8.0.8-osx64_en-US.dmg,
perhaps more Tor Browser users with less experience might complete a proper verification of Tor Browser's signature, and Tor Browser might gain more new users.

Child Tickets

Change History (4)

comment:1 Changed 3 months ago by pili

Cc: pili added
Parent ID: #31296

Making this a child of #31296 since they seem related

comment:2 Changed 3 months ago by dkg

The text listed above is likely to be failing because of the version number (8.0.8) which is embedded in the string.

The replacement proposed here: (gpg --verify ~/Downloads/{.asc,} TorBrowser-8.0.8-osx64_en-US.dmg) does not make any sense to me. the shell should expand this to:

gpg --verify ~/Downloads/.asc ~/Downloads/ TorBrowser-8.0.8-osx64_en-US.dmg

But these three arguments to gpg --verify don't make any sense. gpg --verify can indeed take more than two arguments (though this is highly unusual). But it does not make any sense for one of the arguments to be a directory (~/Downloads/), and it's not clear why there should be any file named ~/Downloads/.asc at all.

The changes over in #31296 convert the instructions to use gpgv but don't abstract away the version number, so may cause problems in the future. but i'll follow up over there.

comment:3 Changed 3 months ago by pili

Owner: changed from hiro to ggus
Status: newassigned

Gus is working on this as part of #31296

comment:4 Changed 3 months ago by ggus

Resolution: fixed
Status: assignedclosed

Fixed following dkg recommendations.

Note: See TracTickets for help on using tickets.