Modify Tor Launcher so it is compatible with ESR68

In addition to removal of overlays (#29197 (moved)), we must make other changes in Tor Launcher for ESR68 compatibility. For example, most of the "on" event attributes within XUL wizard elements have been replaced with events.

added TorBrowserTeam201908R component::applications/tor launcher ff68-esr owner::brade priority::medium resolution::fixed severity::normal sponsor::44-can status::closed tbb-9.0-must-nightly type::defect labels

Here is a patch for review; please read the commit message for more details about what we changed and why: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug29197-01&id=cf26f0d0bd5b1e225ca0dd1c95c8f1c0d33663ea

This patch is on our bug29197-01 branch since it would be best to test this fix with the one for that ticket. So far Kathy and I have only tested on macOS with a non-rbm-based Tor Browser build.

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added

Trac:
Summary: modify Tor Launcher so it is compatible with ESR68 to Modify Tor Launcher so it is compatible with ESR68

acat: could you review and test that patch as well?

Trac:
Cc: tbb-team to tbb-team, acat

No July any longer.

Trac:
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201908R added

Trac:

Trac:

Mostly looks good and works fine for me.

One small question I have regarding the added css:

+groupbox {
+  margin-left: 16px;
+  padding: 8px;
+  background-color: rgba(215, 215, 219, 0.5);

Where does the background-color come from? I checked in my machine with current tor-launcher, and I don't see any background-color difference with the background, but after this patch I do (see screenshots).

I also tested the Request bridge option (had to add bridges to the prefs, otherwise the section does not appear). It fails with Tor unexpectedly closed for me, but it might be an issue that will not reproduce with a properly built nightly, so I'm not sure (I copied the esr68 Firefox built files over a release tor-browser folder).

Replying to acat:

Mostly looks good and works fine for me.

One small question I have regarding the added css:

{{{ +groupbox {

• margin-left: 16px;
• padding: 8px;
• background-color: rgba(215, 215, 219, 0.5); }}}

Where does the background-color come from? I checked in my machine with current tor-launcher, and I don't see any background-color difference with the background, but after this patch I do (see screenshots).

In ESR60, OS styling was used for groupbox. Kathy and I did not realize that it is so different on Linux vs. macOS vs. Windows... we just did something that is similar to the older macOS look. It looks like on Linux there was no styling to "set off" the groupbox contents, while macOS had a darkened background, and Windows 10 had a gray line around the contents. I like the shading/darkened background but we can revisit this later once more people can look at it, e.g., in a nightly build.

Replying to acat:

I also tested the Request bridge option (had to add bridges to the prefs, otherwise the section does not appear). It fails with Tor unexpectedly closed for me, but it might be an issue that will not reproduce with a properly built nightly, so I'm not sure (I copied the esr68 Firefox built files over a release tor-browser folder).

I forgot to mention that moat (aka "Request a bridge") is currently broken due to meek-client-torbrowser's use of an XPCOM extension. Our plan to avoid that problem is #29430 (moved), although there is also #29347 (moved). I added keywords to #29430 (moved).

Replying to mcs:

In ESR60, OS styling was used for groupbox. Kathy and I did not realize that it is so different on Linux vs. macOS vs. Windows... we just did something that is similar to the older macOS look. It looks like on Linux there was no styling to "set off" the groupbox contents, while macOS had a darkened background, and Windows 10 had a gray line around the contents. I like the shading/darkened background but we can revisit this later once more people can look at it, e.g., in a nightly build.

I take back some of what I said. I just looked at your patch.png screnshot and it is not pretty. Maybe we can replace the background color with a simple line border that matches the text color. But if we cannot figure out how to do that, we will just remove the shading and not replace it with anything.

Trac:
Keywords: TorBrowserTeam201908R deleted, TorBrowserTeam201908 added
Status: needs_review to needs_revision

Here is a revised patch: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug31300-02&id=1af54380f289426fea9dfa24c4fd6cf171046723

The only difference is that we replaced the groupbox background-color style with a 1px GrayText border. Alex, it would be great if you could test this on your Linux system to see how it looks.

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201908 deleted, TorBrowserTeam201908R added

Trac:

I think it looks better (see patch2.png). Good enough for the nightly for sure :)

In any case, as you said we can refine later.

Adding Sponsor 44 to ESR68 tickets

Trac:
Sponsor: N/A to Sponsor44-can

Thanks! Merged to master (commit 1af54380f289426fea9dfa24c4fd6cf171046723).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

A follow up ticket for the moat client code: #31487 (moved).

closed

mentioned in issue #31487 (moved)

moved to tpo/applications/tor-launcher#31300 (closed)

mentioned in issue tpo/applications/tor-launcher#31487 (closed)