Opened 7 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#31304 closed enhancement (fixed)

Run practracker_tests.py as part of make check

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: practracker, 042-should, tech-debt, refactoring, easy, network-team-roadmap-july, asn-merge
Cc: nickm, teor Actual Points: .1
Parent ID: #29746 Points:
Reviewer: dgoulet Sponsor:

Description

Running these tests in CI will help avoid future bugs like:

The practracker_tests.py unit test file called a function by its old
name.

This change does not block #29746, but it should be done in 0.4.2.

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by nickm

Actual Points: .1
Status: assignedneeds_review

See branch ticket31304 with PR at https://github.com/torproject/tor/pull/1195 . This is built on #31311, which fixes a bug in how make dist handles the practracker subdirectory.

comment:2 Changed 6 weeks ago by dgoulet

Reviewer: dgoulet

comment:3 Changed 6 weeks ago by dgoulet

Keywords: asn-merge added
Status: needs_reviewmerge_ready

ACK.

comment:4 Changed 6 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged. I guess #31311 can also be closed?

comment:5 Changed 6 weeks ago by nickm

#31311 also needs to go into 0.4.1; I'll backport it now.

Note: See TracTickets for help on using tickets.