Opened 3 months ago

Closed 2 months ago

#31309 closed defect (fixed)

Add envvar to pass options to practracker

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: practracker, tech-debt, refactoring, easy, 041-deferred-20190530, network-team-roadmap-july, dgoulet-merge
Cc: nickm, teor Actual Points: 0
Parent ID: #29746 Points: .1
Reviewer: asn Sponsor: Sponsor31-can

Description

On #30752, catalyst notes:

The Makefile should provide a way to pass command line options in to practracker from the environment, so CI won't have to run practracker by bypassing the Makefile. This can be useful if we want to run with less-friendly options during cron builds, for example.

I agree.

Child Tickets

Change History (5)

comment:1 Changed 3 months ago by nickm

Actual Points: 0
Status: assignedneeds_review

comment:2 Changed 2 months ago by dgoulet

Reviewer: asn

comment:3 Changed 2 months ago by asn

Status: needs_reviewmerge_ready

LGTM!~

comment:4 Changed 2 months ago by nickm

Keywords: dgoulet-merge added

comment:5 Changed 2 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.