Opened 4 months ago

Last modified 8 weeks ago

#31313 needs_review enhancement

Don't rely on RecommendedTBBVersions to create download links

Reported by: phw Owned by:
Priority: Medium Milestone:
Component: Applications/GetTor Version:
Severity: Normal Keywords:
Cc: traumschule, hiro, gaba, phw, cohosh Actual Points:
Parent ID: Points: 0.5
Reviewer: hiro Sponsor:

Description

Over at #31307, we were dealing with a broken GetTor because it made assumptions on the list length available at https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions/. See this comment for more details.

While our emergency fix worked, boklm mentions on IRC that RecommendedTBBVersions is not a good way to learn about the current Tor Browser version:

 20:46  boklm│ RecommendedTBBVersions is not a good way to get the current Tor Browser version
 20:47  boklm│ https://aus1.torproject.org/torbrowser/update_3/release/downloads.json is better
 20:48  boklm│ for example with: wget -q -O - https://aus1.torproject.org/torbrowser/update_3/release/downloads.json | jq -r .version

Let's use this JSON file instead, and make GetTor more robust.

Child Tickets

Change History (2)

comment:1 Changed 4 months ago by phw

Reviewer: hiro
Status: newneeds_review

I have a fix in my fix/31313 branch. While I was at it, I also fixed a number of minor style and formatting issues.

comment:2 Changed 8 weeks ago by cohosh

Cc: cohosh added

cc'ing cohosh on open GetTor tickets.

Note: See TracTickets for help on using tickets.