Opened 3 months ago

Closed 2 months ago

#31320 closed enhancement (implemented)

Add an IPv6 ORPort example to the torrc.minimal.in-staging and torrc.sample.in files

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, ipv6, doc, fast-fix
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: nickm Sponsor:

Description

We don't currently have any IPv6 ORPorts in the example torrc files, but we should.

Child Tickets

Attachments (1)

0001-Add-IPv6-ORPort-examples.patch (1.4 KB) - added by aliraheem 3 months ago.
Diff patch to deal with ticket

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 months ago by teor

Summary: Add an IPv6 ORPort example to the torrcminimal.in-staging and torrc-sample.in filesAdd an IPv6 ORPort example to the torrc.minimal.in-staging and torrc.sample.in files

Changed 3 months ago by aliraheem

Diff patch to deal with ticket

comment:2 Changed 3 months ago by aliraheem

How's this? Also mention the gotchya that you must listen on ipv4

Using information from https://trac.torproject.org/projects/tor/wiki/doc/IPv6RelayHowto

Can also submit via github if that is preferred.

Last edited 3 months ago by aliraheem (previous) (diff)

comment:3 Changed 2 months ago by nickm

Status: newneeds_review

comment:4 Changed 2 months ago by dgoulet

Reviewer: nickm

comment:5 Changed 2 months ago by nickm

Status: needs_reviewneeds_revision

Looks good, one change needed: We never change torrc.minimal.in directly, since whenever it changes, a bunch of operating systems will bug their users about upgrading their configuration files. Instead, we make changs to torrc.minimal.in-staging, and copy them over eventually.

I can make that change if you don't feel like it.

comment:6 Changed 2 months ago by aliraheem

Great, I've made a pull request on github with the appropriate changes https://github.com/torproject/tor/pull/1203

If that still isn't right go a head and make the changes.

Thanks

comment:7 Changed 2 months ago by nickm

Resolution: implemented
Status: needs_revisionclosed

looks good; merged!

Note: See TracTickets for help on using tickets.