Opened 4 months ago

Closed 5 weeks ago

#31335 closed defect (fixed)

make check-includes does not check out of tree builds correctly

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: 043-should, 042-backport, network-team-roadmap-september
Cc: gaba Actual Points: 0.1
Parent ID: #29217 Points: 0.2
Reviewer: Sponsor: Sponsor31-can

Description

I configure tor to build with an out-of-tree build in tor/build-c.

When I run "make check-includes", it checks tor/build-c/src. But it should check tor/src.

I'm marking this as a sponsor 31 roadmap item, because we need to get this check working, so we know that #29217 creates new modules correctly.

Child Tickets

Change History (3)

comment:1 Changed 5 weeks ago by teor

Actual Points: 0.1
Keywords: 042-backport added
Owner: set to teor
Status: newassigned
Version: Tor: 0.3.5.1-alpha

comment:2 Changed 5 weeks ago by teor

Status: assignedmerge_ready

See my PRs:

Testing:

This is an obviously correct fix on already-reviewed code, anyone can merge after CI passes.

comment:3 Changed 5 weeks ago by teor

Milestone: Tor: 0.4.3.x-finalTor: 0.4.2.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.4.2 and later.

Note: See TracTickets for help on using tickets.