Opened 2 months ago

Last modified 3 weeks ago

#31336 needs_review defect

Fix usage for add_c_file.py

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: 0.4.1.2-alpha
Severity: Normal Keywords: 043-should, 042-can network-team-roadmap-september
Cc: nickm, gaba, danielpinto52@… Actual Points:
Parent ID: #29217 Points: 0.1
Reviewer: ahf Sponsor: Sponsor31-can

Description

add_c_file.py was added in commit 2f31c8146f in 0.4.1.2-alpha.

But it has a bug: the suggested usage fails with:

$ scripts/maint/add_c_file.py ./src/feature/dirauth/ocelot.c
Made files successfully but couldn't identify include.am for ./src/feature/dirauth/ocelot.c
Exit 1

The correct usage has no "./":

$ scripts/maint/add_c_file.py src/feature/dirauth/ocelot.c

We should fix the usage, or make topdir_file() use python's canonical path functions.

Child Tickets

Change History (4)

comment:1 Changed 4 weeks ago by Jigsaw52

Status: newneeds_review

I've created a patch that fixes this by using os.path.relpath to get the path relative to ./src.
Both ./src/foo.c and src/foo.c are supported.

Pull request here: https://github.com/torproject/tor/pull/1329

comment:2 Changed 4 weeks ago by nickm

Keywords: 042-can added

comment:3 Changed 4 weeks ago by Jigsaw52

Cc: danielpinto52@… added

comment:4 Changed 3 weeks ago by asn

Reviewer: ahf
Note: See TracTickets for help on using tickets.