#31344 closed defect (fixed)

SecurityLevelPreferences.uninit() never called on exit of about:preferences

Reported by: pospeselr Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201908R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Found this while building out a skeleton for #31286. Looks like I didn't actually register the unload event callback, so the object's observer callback is never removed. Worst case scenario the 'observe' callback will be called for every time the user has entered about:preferences and repeatedly edit the XUL to reflect the changed security_slider value. Not *really* a problem but I'll have a fixup patch shortly.

Child Tickets

Change History (2)

comment:1 Changed 15 months ago by pospeselr

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201908 removed
Status: assignedneeds_review

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_31344

Doing a quick build to verify this doesn't break anything somehow.

EDIT: Confirmed uninit() is now called on about:preferences exit and everything else is working as expected.

Last edited 15 months ago by pospeselr (previous) (diff)

comment:2 Changed 15 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Nice find! Merged to tor-browser-60.8.0esr-9.0-1 (commit d48c3fa6ace654296c78210e370838bcaaf4078c).

Note: See TracTickets for help on using tickets.