Opened 3 months ago

Last modified 4 weeks ago

#31350 new enhancement

test the locales for Android with a githook after updating from transifex

Reported by: emmapeel Owned by: tor-gitadm
Priority: Medium Milestone:
Component: Internal Services/Service - git Version:
Severity: Normal Keywords: TorBrowserTeam201904, GeorgKoppen201904
Cc: emmapeel, igt0, gk, hans@…, ggus, pili Actual Points:
Parent ID: #30054 Points:
Reviewer: Sponsor:

Description

We need to test the correct escaping of the files at https://git.torproject.org/translation.git on the branch tba-torbrowserstringsdtd (only on that branch!)

The files on that branch are used to localize the Android client of the Tor Browser and don't comply with the standards for dtd files. Thus, we need to check on them after updates come from transifex, and before we attempt to build.

Ideally we can produce a list of the corrections, so we can update it on the transifex platform and slowly weed out the errors.

We could reuse this githook for other components eventually, so it would be nice to have some sort of reusable parts:

  • import last translations from transifex
  • run something
  • upload results to transifex?
  • mail or submit results somehow

The script that we can use as a base is at https://trac.torproject.org/projects/tor/ticket/30054#comment:9

the rules at https://developer.android.com/guide/topics/resources/string-resource#FormattingAndStyling may not be all needed, as for example it can be that ' does not break the build.

Child Tickets

Change History (1)

comment:1 Changed 4 weeks ago by eighthave

This is one good example of what Weblate has been doing better than Transifex. It includes a bunch of automatic format checkers that notifies the translators as they are working. I wrote scripts to do this for F-Droid, and now they barely ever catch anything anymore. Here are the scripts currently used for F-Droid Android client. I wrote them, they can be used in Tor under any license that Tor needs.

Note: See TracTickets for help on using tickets.