Opened 15 months ago

Last modified 11 months ago

#31350 needs_information enhancement

test the locales for Android with a githook after updating from transifex

Reported by: emmapeel Owned by: tor-gitadm
Priority: Medium Milestone:
Component: Internal Services/Service - git Version:
Severity: Normal Keywords: TorBrowserTeam201904, GeorgKoppen201904
Cc: emmapeel, igt0, gk, hans@…, ggus, pili Actual Points:
Parent ID: #30054 Points:
Reviewer: Sponsor:


We need to test the correct escaping of the files at on the branch tba-torbrowserstringsdtd (only on that branch!)

The files on that branch are used to localize the Android client of the Tor Browser and don't comply with the standards for dtd files. Thus, we need to check on them after updates come from transifex, and before we attempt to build.

Ideally we can produce a list of the corrections, so we can update it on the transifex platform and slowly weed out the errors.

We could reuse this githook for other components eventually, so it would be nice to have some sort of reusable parts:

  • import last translations from transifex
  • run something
  • upload results to transifex?
  • mail or submit results somehow

The script that we can use as a base is at

the rules at may not be all needed, as for example it can be that ' does not break the build.

Child Tickets

Change History (4)

comment:1 Changed 12 months ago by eighthave

This is one good example of what Weblate has been doing better than Transifex. It includes a bunch of automatic format checkers that notifies the translators as they are working. I wrote scripts to do this for F-Droid, and now they barely ever catch anything anymore. Here are the scripts currently used for F-Droid Android client. I wrote them, they can be used in Tor under any license that Tor needs.

comment:2 Changed 11 months ago by irl

This isn't really a task for the git team, unless I've misunderstood it. Can you use GitLab CI/Travis for this? If you want a tpo hosted solution then this would be a Jenkins task.

comment:3 Changed 11 months ago by irl

Status: newneeds_information

comment:4 Changed 11 months ago by eighthave

This kind of thing could easily run in GitLab CI. Someone just needs to write the required checker scripts. I can throw that up on in a mirror repo, which would automatically run GitLab CI on new commits.

Note: See TracTickets for help on using tickets.