Opened 2 months ago

Closed 2 months ago

#31359 closed enhancement (wontfix)

Split a control_event module out of control, and make it use control safe logging

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: network-team-roadmap-august
Cc: nickm, catalyst, teor Actual Points:
Parent ID: #30901 Points: 2
Reviewer: Sponsor: Sponsor31-can

Description

Currently, control events can log messages through the standard logging module, which can send those logs as control events. This means that some configurations, future code, or errors might cause an infinite loop.

We should split off a control_event or control_log_event module, and make it use control safe logging. All it's dependencies should also use control safe or signal safe logging.

I think we need to make this change after catalyst's control refactor, to avoid merge conflicts.

Child Tickets

Change History (2)

comment:1 Changed 2 months ago by teor

We might not do this ticket: if nickm's idea of stopping control logging during a trace log works, then the code becomes much simpler.

comment:2 Changed 2 months ago by teor

Resolution: wontfix
Status: assignedclosed
Note: See TracTickets for help on using tickets.