Opened 6 weeks ago

Closed 5 weeks ago

#31361 closed enhancement (implemented)

Remove Cobertura from our build process

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: irl Sponsor:

Description

We're having trouble with Cobertura, and we noticed that we're not really using it that much: One issue is an UnsupportedClassVersionError (#31233), another issue is a CI fail due to line coverage rate of 91.6% being below 92.0% on the CI host which doesn't show on my dev machine.

Without having hard evidence, I suspect that these issues are in one way or another related to Cobertura not being maintained anymore with its last release being from February 2015.

Let's remove Cobertura from our build process. We can later switch to using something else that GitLab can actually interpret the output of.

I didn't work on these changes yet, but I think this mainly requires changes to metrics-base and a subsequent update in all depending code bases. I'll work on this later today or tomorrow.

Child Tickets

Change History (3)

comment:1 Changed 6 weeks ago by karsten

Reviewer: irl
Status: assignedneeds_review

Removed in metrics-base commit 75cda35 and metrics-lib commit 53b16d1 and pushed to master to see if CI is happy with it. If these look okay, I'll update the other code bases.

comment:2 Changed 6 weeks ago by irl

Status: needs_reviewmerge_ready

This looks good to me. It is not easy to run this in the CI without the metrics-base commit already being pushed, but I duplicated the CI locally (it just runs in Docker) and ran it manually and it worked.

comment:3 Changed 5 weeks ago by karsten

Resolution: implemented
Status: merge_readyclosed

Ah, I had already pushed changes to metrics-base, because they seemed trivial enough. So, in theory, it should also run in the CI. Glad to hear it also ran in the locally run CI. Thanks for checking!

I went ahead an pushed the remaining changes in CollecTor commit 8010084, Onionoo commit 301841c, ExoneraTor commit 4654ff9, and metrics-web commit a881d0f. These also seemed trivial enough that they don't require review before pushing them to master.

Closing as implemented. If something comes up when putting out the next round of releases we can always re-open this ticket. Thanks!

Note: See TracTickets for help on using tickets.