Opened 6 weeks ago

Closed 4 weeks ago

#31366 closed defect (fixed)

Move the connection_edge_process_relay_cell() assignment out of the if statement in circuit_receive_relay_cell()

Reported by: neel Owned by: neel
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, fast-fix
Cc: neel Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

As mentioned in #31207 by nickm:

This is fine. I'd also take a patch to extract the assignment entirely, since using assignment in this way is error-prone.

Child Tickets

Change History (7)

comment:1 Changed 6 weeks ago by neel

Component: - Select a componentCore Tor/Tor

Add component

comment:2 Changed 6 weeks ago by teor

Keywords: technical-debt fast-fix added
Milestone: Tor: unspecified

comment:3 Changed 6 weeks ago by neel

Status: assignedneeds_review

comment:4 Changed 6 weeks ago by teor

Milestone: Tor: unspecifiedTor: 0.4.2.x-final

comment:5 Changed 5 weeks ago by asn

Reviewer: asn

comment:6 Changed 5 weeks ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:7 Changed 4 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.