#31373 closed enhancement (implemented)

Print summary of features at end of configure

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: configure, build
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: nickm Sponsor:

Description

I came across this summary with colors in another open source project. I borrowed their m4 pretty print macro that is GPLv2.

I took 15 minutes to make this and it is actually very useful to have such a summary at the end of configure time instead of looking at config.log all the time to make sure what you have enabled.

See attachment for the end result.

Child Tickets

Attachments (1)

configure.png (49.6 KB) - added by dgoulet 15 months ago.

Download all attachments as: .zip

Change History (12)

Changed 15 months ago by dgoulet

Attachment: configure.png added

comment:1 Changed 15 months ago by dgoulet

Status: assignedneeds_review

Ticket: ticket31373_042_01
PR: https://github.com/torproject/tor/pull/1218

comment:2 Changed 15 months ago by nickm

Neat idea; let's see if we can get a GPL exception for the script, though.

comment:3 Changed 15 months ago by nickm

Status: needs_reviewneeds_revision

comment:4 Changed 14 months ago by dgoulet

Waiting on this patch to be merged upstream in the project I borrowed this .m4:

https://lists.lttng.org/pipermail/lttng-dev/2019-August/029189.html

I was told there shouldn't be a problem with that so hopefully soon!

comment:5 Changed 14 months ago by dgoulet

Status: needs_revisionneeds_review

Author merged the special permission to the file: https://git.lttng.org/?p=lttng-tools.git;a=blob;f=m4/pprint.m4;h=a18a2ac6bf73bcc6bf42730eb9c08344cc2e25f8;hb=HEAD

So we can proceed with this. I've pushed the update on the branch rebased on master and with the new license from upstream.

comment:6 Changed 14 months ago by nickm

Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

comment:7 Changed 14 months ago by nickm

Status: needs_reviewneeds_revision

Okay, this is looking like a good start. I've added a bunch of little comments on the branch. Let's target this for 0.4.3.

comment:8 Changed 13 months ago by dgoulet

Status: needs_revisionneeds_review

Addressed it all nickm! Great suggestions, I hope the new output pleases you :).

comment:9 Changed 13 months ago by nickm

Status: needs_reviewneeds_revision

Looks okay to me now! Please add a changes file?

comment:10 Changed 13 months ago by dgoulet

Status: needs_revisionneeds_review

Pushed!

comment:11 Changed 13 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Great; merged!

Note: See TracTickets for help on using tickets.