Opened 6 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#31376 closed enhancement (fixed)

Make a /metrics handle at the snowflake broker for the stats collector

Reported by: cohosh Owned by: cohosh
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: metrics, stats, broker
Cc: irl, karsten, arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points: 1
Reviewer: phw Sponsor: Sponsor28

Description

We have metrics being written to a log file for now as specified in #21315, and the metrics team is working on setting up a collector module for it in #29461. We should add a handler at the broker at snowflake-broker@bamsoftware.com/metrics so the collector can make GET requests for the collected metrics.

The response should be
Content-Type: text/plain; charset=utf-8

Child Tickets

Change History (7)

comment:1 Changed 6 weeks ago by cohosh

Actual Points: 1
Points: 1

comment:2 Changed 6 weeks ago by cohosh

Status: assignedneeds_information

Got a start on this handler here: https://github.com/cohosh/snowflake/commit/f0e71c7c58f72118313c28c1d90ec4fdfb74a23f

I'm not sure what range of data the metrics team needs here. Is it just the last full 24 hour measurement period? Do you need the ability to also fetch previous measurement periods as well?

comment:3 Changed 5 weeks ago by cohosh

Status: needs_informationneeds_review

After talking to karsten in #29461, here's a better way of providing all previously logged metrics: https://github.com/cohosh/snowflake/compare/ticket31376_v2

comment:4 Changed 5 weeks ago by phw

Reviewer: phw

comment:5 Changed 5 weeks ago by phw

Status: needs_reviewneeds_information

I only had a minor comment, which may or may not need a revision. Otherwise the patch looks good to me.

comment:6 in reply to:  5 Changed 5 weeks ago by cohosh

Resolution: fixed
Status: needs_informationclosed

Replying to phw:

I only had a minor comment, which may or may not need a revision. Otherwise the patch looks good to me.

Thanks! Fixed and merged in 0aef40100a.

comment:7 Changed 4 weeks ago by cohosh

Noting that this has been deployed at the broker as of 2019/08/23 15:24:09

Note: See TracTickets for help on using tickets.