localize snowflake website
https://snowflake.torproject.org/ should appear at least on our priority 12 languages.
Activity
The file at https://gitweb.torproject.org/pluggable-transports/snowflake.git/tree/proxy/static/index.html (thanks cohosh) is easily translatable, but i am not sure how users will change from one language to the other.
i could provide a folder with different translations of the index.html page to be loaded as a git submodule, if you want, i.e.:
translations/ index+fr.html index+de.html etc
Then, we just need to add a little menu with the translated languages on top.
what do you think?
-
the translations of the web interface are available at
https://gitweb.torproject.org/translation.git/log/?h=snowflake-website-indexhtml
i.e. repo https://git.torproject.org/translation.git
branch snowflake-website-indexhtml
Please let me know if you can use them to provide a localized version of the webpage.
Trac:
Status: new to needs_review Replying to emmapeel:
Please let me know if you can use them to provide a localized version of the webpage.
I have some process-related questions.
How do we know which language to use? In comment:2 you mentioned adding a menu to the page. I see such a menu at https://tb-manual.torproject.org/, defaulting(?) to English. Should we also look at the
Accept-LanguageHTTP header (i.e., the user's in-browser configured language)? Do other Tor Project pages do that?What is the process for handling revisions to the source text? Will the translation.git repository periodically get a revised index.html, then make changes in that repository? Then we import those changes back into snowflake.git? Is there some way to notify each group about when updates are ready from the other side?
Trac:
Status: needs_review to needs_information
Keywords: snowflake-webextension deleted, N/A added
Replying to dcf:
Replying to emmapeel:
Please let me know if you can use them to provide a localized version of the webpage.
I have some process-related questions.
How do we know which language to use? In comment:2 you mentioned adding a menu to the page. I see such a menu at https://tb-manual.torproject.org/, defaulting(?) to English. Should we also look at the
Accept-LanguageHTTP header (i.e., the user's in-browser configured language)? Do other Tor Project pages do that?Looks like arlo's most recently changes in #30310 (moved) use the navigator.language property to set the translation and default to English if none exist. See https://github.com/keroserene/snowflake/commit/da21c6710cd871d931f2eea2a185b78b1907d3db#diff-c371ea9d4448f98b3fda1dfca95c925eR93
Trac:
Parent: #30310 (moved) to N/A-
Replying to dcf:
I have some process-related questions.
How do we know which language to use? In comment:2 you mentioned adding a menu to the page. I see such a menu at https://tb-manual.torproject.org/, defaulting(?) to English. Should we also look at the
Accept-LanguageHTTP header (i.e., the user's in-browser configured language)? Do other Tor Project pages do that?The ideal will be to allow users to change it by hand, as our own browser allows to hide your language and many people browse the web in English because of fingerprinting, or sometimes are using public computers, etc, so it is unlikely that they will have the proper language configured.
What is the process for handling revisions to the source text? Will the translation.git repository periodically get a revised index.html, then make changes in that repository? Then we import those changes back into snowflake.git? Is there some way to notify each group about when updates are ready from the other side?
I can hook the translation system to the repository at https://gitweb.torproject.org/pluggable-transports/snowflake.git/plain/proxy/static/index.html, so the changes on the file will be reflected some hours later on the translation platform (i have done that already with messages.json). transifex will pull the source files twice a day I think.
It would be great if somebody from the team can join transifex, as sometimes there are comments translators do on the source strings that would be nice if you review.
From inside of transifex you could see if the file is translated and reviewed, the comments, etc.
I can help you decide on the languages that are ready when you approach release.
We could also make a call for translations to speed up the process, currently many languages are translated but not reviewed.
Also, if you have friends that want to review a specific language before publishing, send them to me, as we need trusted reviewers for many languages.
-
I've started working on this, I think having full index.html files will be difficult to deal with and is different from how we are doing things the webextension and also different from how bridges.tp.o and gettor.tp.o work.
I've started expanding messages.json with the website text but if there's a better way to do this, let me know :)
Trac:
Status: needs_information to assigned
Owner: N/A to cohosh -
It won't work right now because I need to hook up the .js fill function, but this is an idea of what it looks like: https://github.com/cohosh/snowflake/tree/ticket31384
-
Okay I've been thinking more about how to structure this. https://snowflake.torproject.org is structured a bit differently from other anti-censorship tp.o sites and therefore does localization differently.
For example, bridgeDB and gettor both use python to render the site and python libraries for localization. The snowflake webextension uses messages.json for each string in the webextension.
It looks like right now the translation repository for this website is set up to translate the
index.htmlfile entirely: https://gitweb.torproject.org/translation.git/tree/?h=snowflake-website-indexhtml_completedIs this how we want to do this? I'm curious about how the rest of tp.o handles localization here. Also, it looks like the index.html file being used by transifex doesn't quite match the index.html file in
proxy/static/.Does it make incremental changes to index.html harder to update?
Trac:
Cc: emmapeel, dcf, arlolra, cohosh, phw to emmapeel, dcf, arlolra, cohosh, phw, hiro Replying to cohosh:
It looks like right now the translation repository for this website is set up to translate the
index.htmlfile entirely: https://gitweb.torproject.org/translation.git/tree/?h=snowflake-website-indexhtml_completedIs this how we want to do this? I'm curious about how the rest of tp.o handles localization here. Also, it looks like the index.html file being used by transifex doesn't quite match the index.html file in
proxy/static/.That's partly my fault, because I did some HTML and CSS refactoring changes not knowing that the translation repository existed.
I can see how merging changes like that will be annoying to translators. But if we don't anticipate index.html being changed that often, I'm fine with translating the whole file as a "worse-is-better" approach.
-
Replying to cohosh:
Is this how we want to do this? I'm curious about how the rest of tp.o handles localization here.
- Some applications handle it with po4a and provide me of a .pot file and i give them the different language .po files
- the resources used by TBB are mozilla localization dtd and properties files
- the index file i added directly using the transifex framework because it was an easy html file... maybe that is not the case anymore?
- some markdown files are translated directly
Also, it looks like the index.html file being used by transifex doesn't quite match the index.html file in
proxy/static/.This was because i didnt have it configured to pull daily from it. This is fixed now, and the file has been refreshed. Transifex will look it up twice a day and update it automatically.
-
Replying to cohosh:
I've started working on this, I think having full index.html files will be difficult to deal with and is different from how we are doing things the webextension and also different from how bridges.tp.o and gettor.tp.o work.
I've started expanding messages.json with the website text but if there's a better way to do this, let me know :) Oh yes, json files are also a good match and they are better than the html straight.
Sorry I just read this comment now, but yeah that would be much better
Replying to cohosh:
It won't work right now because I need to hook up the .js fill function, but this is an idea of what it looks like: https://github.com/cohosh/snowflake/tree/ticket31384
If you want to do it this way, I would suggest not doing
<h2>__MSG_browser__</h2>but instead something like
<h2 data-msgid="__MSG_browser__">Browser</h2>That way, a failure of the fill function, or a missing translation, will at least show English text rather than a raw message identifier. The data- attribute prefix can be used to attach arbitrary information to HTML elements.
__MSG_either__<a href="https://trac.torproject.org/projects/tor/register">__MSG_createAccount__</a> __MSG_or__ <a href="https://trac.torproject.org/projects/tor/login">log in</a> __MSG_usingShared__<b>cypherpunks</b> __MSG_withPassword__ <b>writecode</b>.</li>I'm guessing that this kind of structure will be difficult to translate because the translator cannot change the order of the
<a></a>and<b></b>fragments. It may be better to allow HTML in the replacement strings.-
Okay here's my current progress on this ticket: https://github.com/cohosh/snowflake/compare/website-translation
I switched to using messages.json and took dcf's advice of using the
data-msgidattribute to set the key for the localized strings.Tomorrow I'll add a dropdown language switcher as in #26543 (moved), and see if we should do something different for rtl languages.
Trac:
Status: needs_information to accepted -
Done implementing this language switcher. Here's a pull request: https://github.com/cohosh/snowflake/pull/9
Note that because we're using the same messages.json file as the webextension for the translations, we won't need two different translation repositories.
Trac:
Status: accepted to needs_review
