Opened 4 months ago

Closed 3 months ago

#31400 closed enhancement (fixed)

Add Onionoo's master branch to GitLab's CI

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: #31398 Points:
Reviewer: Sponsor:

Description


Child Tickets

Change History (2)

comment:1 Changed 3 months ago by irl

Status: newneeds_review

Two commits here, because a test was timing out in the GitLab CI environment.

Please review:

  1. https://dip.torproject.org/irl/onionoo/commit/5173fe1d73c32342be937160d4974bd446c45e57
  2. https://dip.torproject.org/irl/onionoo/commit/4ba7b00c6f4080955af907e1dbf9dd0c79fb9a58

My assumption is that we are testing correctness here, not speed of the function, maybe doubling the timeout was too much.

comment:2 Changed 3 months ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged! Looks like it worked. Closing.

Note: See TracTickets for help on using tickets.