Opened 10 months ago

Closed 2 months ago

#31414 closed task (fixed)

Review, fix and/or ignore linter errors found by cfn-lint

Reported by: irl Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Cloud Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Example, maybe not the latest commit: https://dip.torproject.org/torproject/metrics/metrics-cloud/-/jobs/36

The scripts work as far as they do what I intended them to, but maybe they use deprecated things or are fragile. This is not super urgent but it would be good to have this passing in GitLab so it's obvious when we introduce new errors.

Child Tickets

Change History (2)

comment:1 Changed 2 months ago by irl

There appears to be some confusion over what to do for DNS RR TTL: https://github.com/aws-cloudformation/cfn-python-lint/issues/1425

AWS staff don't even know what type to put there.

comment:2 Changed 2 months ago by irl

Resolution: fixed
Status: newclosed

I've relaxed the strict checking of the DNS RR TTL type, and we are using string when it says string in the docs, so this is probably fine. Left a comment in the travis yaml to check up on this again in the future. All other issues are now resolved.

Note: See TracTickets for help on using tickets.