Opened 3 months ago

Closed 3 months ago

#31447 closed defect (fixed)

Don't install python just for mach

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201908R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

We are currently installing python just for mach. If we need an extra Python here then we should use the one we build ourselves already (or amend that so that it can be used).

Child Tickets

Change History (3)

comment:1 Changed 3 months ago by boklm

Keywords: TorBrowserTeam201908R added
Status: newneeds_review

The python we are building is version 3.6.8. However, the page about mach says:

Mach also requires Python 2.7. Mach itself is Python 3 compliant, but modules used by mach likely are not Python 3 compliant - so stick to Python 2.7.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/mach

So unless this page is outdated, it looks correct to install two different versions of python.

In branch bug_31447_v2 I added a patch updating the comment about the python package:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_31447_v2&id=ace69bc2a6abb9bc5aaba625eb9a693ae2e2a5c7

comment:2 Changed 3 months ago by pili

Sponsor: Sponsor44-can

Tagging with Sponsor 44

comment:3 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, makes sense, thanks! Merged to master (commit 00354e514c96c25dea3107a8240249063526a29a).

Note: See TracTickets for help on using tickets.