Opened 5 weeks ago

Closed 4 weeks ago

#31451 closed defect (fixed)

CID 1452041: Use 64-bit literal in parse_log_domain()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: catalyst Sponsor:

Description

We use (1u<<i) as the value for a log domain mask here, but this will fail on 32-bit systems once we have more than 32 log domains. Fortunately, we aren't there yet: the extra bits are only used for flags. Still, we should fix this.

Child Tickets

Change History (6)

comment:1 Changed 5 weeks ago by nickm

Points: 0

comment:2 Changed 5 weeks ago by nickm

Actual Points: 0
Status: assignedneeds_review

comment:3 Changed 4 weeks ago by dgoulet

Reviewer: catalyst

comment:4 in reply to:  2 Changed 4 weeks ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

Branch is bug31451; pr in https://github.com/torproject/tor/pull/1237

Thanks! Looks good to me.

comment:5 Changed 4 weeks ago by nickm

Keywords: asn-merge added

comment:6 Changed 4 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.