Opened 2 months ago

Closed 2 months ago

#31452 closed defect (fixed)

Fix coverity failures in unit tests as of 19 August 2019

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: dgoulet-merge
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: catalyst Sponsor:

Description

Other than #31451 and a deadcode issue in trunnel, our current "new" and "triaged" issues are all in the unit tests.

Let's fix them all, to keep our code quality up.

Child Tickets

Change History (6)

comment:1 Changed 2 months ago by nickm

Points: 0.5

comment:2 Changed 2 months ago by nickm

Points: 0.50.1

It turns out there is only one of these: CID 1447292

comment:3 Changed 2 months ago by nickm

Actual Points: 0.1
Status: assignedneeds_review

See branch bug31452 with PR at https://github.com/torproject/tor/pull/1239 .

comment:4 Changed 2 months ago by dgoulet

Reviewer: catalyst

comment:5 in reply to:  3 Changed 2 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

See branch bug31452 with PR at https://github.com/torproject/tor/pull/1239 .

Thanks! This looks good.

comment:6 Changed 2 months ago by dgoulet

Keywords: dgoulet-merge added
Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.