Opened 5 months ago

Closed 5 months ago

#31453 closed enhancement (fixed)

Are the @2x and @3x graphics doing anything?

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: snowflake-webextension
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The proxy/static/assets directory contains @2x and @3x hi-res versions of the status-off, status-on, and status-running icons.

But the @2x and @3x filenames are not referred to anywhere. I suspect they were intended to be included in a resolution @media query, but they are not.

Rather than adding the @media queries, could we just delete all the PNGs and use only SVGs in the popup? In the toolbar icon we cannot use SVG, but those graphics are separate from the popup ones.

Child Tickets

Change History (3)

comment:2 Changed 5 months ago by arlolra

Status: needs_reviewmerge_ready

But the @2x and @3x filenames are not referred to anywhere. I suspect they were intended to be included in a ​resolution @media query, but they are not.

Yeah, they were from the initial bulk import and we haven't gotten around to using them,
https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=5b18729e77d7e69df8b91801e13fc123050acd8c

Note: See TracTickets for help on using tickets.